Summary

Change method of passing request into logging methods.

Review Request #13632 — Created March 15, 2024 and submitted March 18, 2024, 1:19 p.m.

Information

Owner

david

Repository

rbintegrations

Branch

master

Bugs

Depends On

Reviewers

Groups

rbintegrations

People

Description

In order to avoid typechecking warnings, we've changed the official way
of passing the request into the logger to use the extra argument
instead of our own custom arg. This change updates rbintegrations to use
that.

Testing Done

Ran unit tests, no longer saw deprecation warnings.

Commits

Summary	ID
Change method of passing request into logging methods. In order to avoid typechecking warnings, we've changed the official way of passing the request into the logger to use the `extra` argument instead of our own custom arg. This change updates rbintegrations to use that. Testing Done: Ran unit tests, no longer saw deprecation warnings.	c931a3f54a99146c2f44d2fe0a29636a24e0d446

Issues

Description	From	Last Updated
undefined name 'request' Column: 48 Error code: F821	reviewbot	March 15, 2024, 1:06 p.m.
undefined name 'request' Column: 48 Error code: F821	reviewbot	March 15, 2024, 1:06 p.m.

flake8 failed.

JSHint passed.

flake8

rbintegrations/travisci/forms.py (Diff revision 1)
The issue has been dropped. Show all issues
```
undefined name 'request'

Column: 48
Error code: F821
```
rbintegrations/travisci/forms.py (Diff revision 1)
The issue has been dropped. Show all issues
```
undefined name 'request'

Column: 48
Error code: F821
```

Commits:

	Summary	ID
	Change method of passing request into logging methods. In order to avoid typechecking warnings, we've changed the official way of passing the request into the logger to use the `extra` argument instead of our own custom arg. This change updates rbintegrations to use that. Testing Done: Ran unit tests, no longer saw deprecation warnings.	47bf96943ba55abfef97a94b730571acceaf3113
	Change method of passing request into logging methods. In order to avoid typechecking warnings, we've changed the official way of passing the request into the logger to use the `extra` argument instead of our own custom arg. This change updates rbintegrations to use that. Testing Done: Ran unit tests, no longer saw deprecation warnings.	c931a3f54a99146c2f44d2fe0a29636a24e0d446

Diff:

Revision 2 (+46 -28)

Show changes

	rbintegrations/circleci/views.py
	rbintegrations/travisci/forms.py
	rbintegrations/travisci/views.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to master (6df8981)