Summary

Fix BaseResourceModel.save to not assume that options is non-null.

Review Request #13612 — Created March 5, 2024 and submitted March 18, 2024, 8:39 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-7.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

In the vast majority of cases, calling save() on a resource will
either include a caller-provided options object, or will get the
default value from being unspecified. The one case I've found where this
is not the case is Backbone.Collection.create(), which explicitly
calls save() on the object with a null options.

This change bullet-proofs that so we don't crash.

Testing Done

Saw that I could use code that called Collection.create without it
hitting an error.

Commits

Summary	ID
Fix BaseResourceModel.save to not assume that options is non-null. In the vast majority of cases, calling `save()` on a resource will either include a caller-provided `options` object, or will get the default value from being unspecified. The one case I've found where this is not the case is `Backbone.Collection.create()`, which explicitly calls `save()` on the object with a `null` options. This change bullet-proofs that so we don't crash. Testing Done: Saw that I could use code that called `Collection.create` without it hitting an error.	49d8aca06645b12c8a43654be84528aa096be03c

Summary

Fix BaseResourceModel.save to not assume that options is non-null.

In the vast majority of cases, calling `save()` on a resource will either include a caller-provided `options` object, or will get the default value from being unspecified. The one case I've found where this is not the case is `Backbone.Collection.create()`, which explicitly calls `save()` on the object with a `null` options. This change bullet-proofs that so we don't crash. Testing Done: Saw that I could use code that called `Collection.create` without it hitting an error.

49d8aca06645b12c8a43654be84528aa096be03c

Issues

Description	From	Last Updated
You can do options \|\|= {}; Alternatively, if we only want to do this for null/undefined (rather than falsy values), …	chipx86	March 18, 2024, 8:38 p.m.

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

reviewboard/static/rb/js/common/resources/models/baseResourceModel.ts (Diff revision 1)

The issue has been resolved. Show all issues

You can do options ||= {};
Alternatively, if we only want to do this for null/undefined (rather than falsy values), ??= works.

Status:: Completed
Change Summary:: Pushed to release-7.x (8d5c6c8)