Summary

Implement binary files support for Mercurial.

Review Request #13610 — Created March 4, 2024 and submitted April 1, 2024, 3:17 p.m.

Information

Owner

david

Repository

RBTools

Branch

release-5.x

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

This change implements the get_file_content and get_file_size methods
for the Mercurial client backend.

Additionally, this changes the log methods to always use {node}
instead of {node|short}. We had a mix (individual commits were using
the full node SHA, while the cumulative diff was using the short form),
which was causing issues with file uploads--we'd upload a file for the
commit version with the full SHA revision, and then not find it because
the cumulative diff was using the short SHA.

Testing Done


Ran unit tests.
Uploaded a variety of revisions including binary files. Saw that

  everything worked correctly.

Commits

Summary	ID
Implement binary files support for Mercurial. This change implements the get_file_content and get_file_size methods for the Mercurial client backend. Additionally, this changes the log methods to always use `{node}` instead of `{node\|short}`. We had a mix (individual commits were using the full node SHA, while the cumulative diff was using the short form), which was causing issues with file uploads--we'd upload a file for the commit version with the full SHA revision, and then not find it because the cumulative diff was using the short SHA. Testing Done: - Ran unit tests. - Uploaded a variety of revisions including binary files. Saw that everything worked correctly.	fbae529dfe7465670ffc226b658d0092d8828468

Summary

Implement binary files support for Mercurial.

This change implements the get_file_content and get_file_size methods for the Mercurial client backend. Additionally, this changes the log methods to always use `{node}` instead of `{node|short}`. We had a mix (individual commits were using the full node SHA, while the cumulative diff was using the short form), which was causing issues with file uploads--we'd upload a file for the commit version with the full SHA revision, and then not find it because the cumulative diff was using the short SHA. Testing Done: - Ran unit tests. - Uploaded a variety of revisions including binary files. Saw that everything worked correctly.

fbae529dfe7465670ffc226b658d0092d8828468

Issues

Description	From	Last Updated
Can we add unit tests for this?	chipx86	March 26, 2024, 10:03 p.m.
This comment probably doesn't make sense here.	chipx86	March 4, 2024, 6:46 p.m.
This can be one statement.	chipx86	March 4, 2024, 6:46 p.m.
This doesn't make sense here.	chipx86	March 4, 2024, 6:46 p.m.
This can be one statement.	chipx86	March 4, 2024, 6:46 p.m.
Swap these.	chipx86	April 1, 2024, 2:55 p.m.

flake8 passed.

JSHint passed.

rbtools/clients/mercurial.py (Diff revision 1)
The issue has been resolved. Show all issues
```
This comment probably doesn't make sense here.
```
rbtools/clients/mercurial.py (Diff revision 1)
The issue has been resolved. Show all issues
```
This can be one statement.
```
rbtools/clients/mercurial.py (Diff revision 1)
The issue has been resolved. Show all issues
```
This doesn't make sense here.
```

rbtools/clients/mercurial.py (Diff revision 1)

The issue has been dropped. Show all issues

This can be one statement.

david March 4, 2024, 6:47 p.m.

I think I'd prefer to keep it separate for now because otherwise the int() kind of gets visually lost.

Commits:

	Summary	ID
	Implement binary files support for Mercurial. This change implements the get_file_content and get_file_size methods for the Mercurial client backend. Additionally, this changes the log methods to always use `{node}` instead of `{node\|short}`. We had a mix (individual commits were using the full node SHA, while the cumulative diff was using the short form), which was causing issues with file uploads--we'd upload a file for the commit version with the full SHA revision, and then not find it because the cumulative diff was using the short SHA. Testing Done: - Ran unit tests. - Uploaded a variety of revisions including binary files. Saw that everything worked correctly.	6170a01cb0ec5f908448de8a32e13953078af7ca
	Implement binary files support for Mercurial. This change implements the get_file_content and get_file_size methods for the Mercurial client backend. Additionally, this changes the log methods to always use `{node}` instead of `{node\|short}`. We had a mix (individual commits were using the full node SHA, while the cumulative diff was using the short form), which was causing issues with file uploads--we'd upload a file for the commit version with the full SHA revision, and then not find it because the cumulative diff was using the short SHA. Testing Done: - Ran unit tests. - Uploaded a variety of revisions including binary files. Saw that everything worked correctly.	6468061ca8f5cd0fb84d74d521b178492f98e8a2

Diff:

Revision 2 (+126 -8)

Show changes

rbtools/clients/mercurial.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

The issue has been resolved. Show all issues
```
Can we add unit tests for this?
```

Commits:

	Summary	ID
	Implement binary files support for Mercurial. This change implements the get_file_content and get_file_size methods for the Mercurial client backend. Additionally, this changes the log methods to always use `{node}` instead of `{node\|short}`. We had a mix (individual commits were using the full node SHA, while the cumulative diff was using the short form), which was causing issues with file uploads--we'd upload a file for the commit version with the full SHA revision, and then not find it because the cumulative diff was using the short SHA. Testing Done: - Ran unit tests. - Uploaded a variety of revisions including binary files. Saw that everything worked correctly.	6468061ca8f5cd0fb84d74d521b178492f98e8a2
	Implement binary files support for Mercurial. This change implements the get_file_content and get_file_size methods for the Mercurial client backend. Additionally, this changes the log methods to always use `{node}` instead of `{node\|short}`. We had a mix (individual commits were using the full node SHA, while the cumulative diff was using the short form), which was causing issues with file uploads--we'd upload a file for the commit version with the full SHA revision, and then not find it because the cumulative diff was using the short SHA. Testing Done: - Ran unit tests. - Uploaded a variety of revisions including binary files. Saw that everything worked correctly.	fbae529dfe7465670ffc226b658d0092d8828468

Diff:

Revision 3 (+296 -50)

Show changes

	rbtools/clients/mercurial.py
	rbtools/clients/tests/test_mercurial.py
	rbtools/clients/tests/testdata/hg-repo/.hg/dirstate

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

rbtools/clients/tests/test_mercurial.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Swap these.
```

Status: Closed (submitted)

Change Summary:

Pushed to release-5.x (dea0af9)