Handle uploading source versions of binaries when needed.

 






 

 


  Review Request #13608
  —
  Created March 4, 2024 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  david
 









 
 

  RBTools
 









 
 

  release-5.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  rbtools
 









 
 

  
 






 








 





  


 
 

  
When a change involving binary files is uploaded that requires a parent

diff, we need to upload both the modified and source versions of the

binary file (since the server can't fetch the source version from the

repository). This change handles that, with the new source_file

parameter to the diff file attachments API.

 








  


 
 

  
Uploaded changes to binary files that required a parent diff.

Saw the correct version of the source file.

 







 









 





  








 




 







   

    
    
Diff Revision 2


This is not the most recent revision of the diff. The latest diff is revision 3. See what's changed.

    

 

 

 

 
orig
1
2
3

 



    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    

     Handle uploading source versions of binaries when needed.
     
When a change involving binary files is uploaded that requires a parent
diff, we need to upload both the modified and source versions of the
binary file (since the server can't fetch the source version from the
repository). This change handles that, with the new `source_file`
parameter to the diff file attachments API.

Testing Done:
Uploaded changes to binary files that required a parent diff. Saw the
correct version of the source file.

    

   
  		
  be2074f852432ebe140be0f96af725ff3bc11529
  David Trowbridge
 




    


    
    

   

  

 









 

  

   
    

     
      
      rbtools/api/resource.py
     
    

   
  

 



 

  

   
    

     
      
      rbtools/commands/post.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...