Summary

Handle uploading source versions of binaries when needed.

Review Request #13608 — Created March 4, 2024 and submitted March 26, 2024, 10:20 p.m.

Information

Owner

david

Repository

RBTools

Branch

release-5.x

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

When a change involving binary files is uploaded that requires a parent
diff, we need to upload both the modified and source versions of the
binary file (since the server can't fetch the source version from the
repository). This change handles that, with the new source_file
parameter to the diff file attachments API.

Testing Done

Uploaded changes to binary files that required a parent diff.
Saw the correct version of the source file.

Commits

Summary	ID
Handle uploading source versions of binaries when needed. When a change involving binary files is uploaded that requires a parent diff, we need to upload both the modified and source versions of the binary file (since the server can't fetch the source version from the repository). This change handles that, with the new `source_file` parameter to the diff file attachments API. Testing Done: Uploaded changes to binary files that required a parent diff. Saw the correct version of the source file.	14e09be42208b81cb174732e192e95d2da443800

Summary

Handle uploading source versions of binaries when needed.

When a change involving binary files is uploaded that requires a parent diff, we need to upload both the modified and source versions of the binary file (since the server can't fetch the source version from the repository). This change handles that, with the new `source_file` parameter to the diff file attachments API. Testing Done: Uploaded changes to binary files that required a parent diff. Saw the correct version of the source file.

14e09be42208b81cb174732e192e95d2da443800

Issues

Description	From	Last Updated
Can we make this keyword-only? (Ideally everything.)	chipx86	March 4, 2024, 6:48 p.m.
Missing version information. Also, this needs , optional.	chipx86	March 4, 2024, 6:48 p.m.
These should be typed.	chipx86	March 4, 2024, 6:49 p.m.
Can we show what these mimetypes are?	chipx86	March 4, 2024, 6:50 p.m.
Worth putting the mimetype in here?	chipx86	March 18, 2024, 3:29 p.m.

flake8 passed.

JSHint passed.

rbtools/api/resource.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Can we make this keyword-only? (Ideally everything.)
```

rbtools/api/resource.py (Diff revision 1)

The issue has been resolved. Show all issues

Missing version information.

Also, this needs , optional.

david March 4, 2024, 6:50 p.m.

This whole resource specialization is new.

rbtools/commands/post.py (Diff revision 1)
The issue has been resolved. Show all issues
```
These should be typed.
```
rbtools/commands/post.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Can we show what these mimetypes are?
```

Commits:

	Summary	ID
	Handle uploading source versions of binaries when needed. When a change involving binary files is uploaded that requires a parent diff, we need to upload both the modified and source versions of the binary file (since the server can't fetch the source version from the repository). This change handles that, with the new `source_file` parameter to the diff file attachments API. Testing Done: Uploaded changes that required a binary file. Saw the correct version of the source file.	6f057021ad7535213587bc8eedd5c14882e91e8d
	Handle uploading source versions of binaries when needed. When a change involving binary files is uploaded that requires a parent diff, we need to upload both the modified and source versions of the binary file (since the server can't fetch the source version from the repository). This change handles that, with the new `source_file` parameter to the diff file attachments API. Testing Done: Uploaded changes to binary files that required a parent diff. Saw the correct version of the source file.	be2074f852432ebe140be0f96af725ff3bc11529

Diff:

Revision 2 (+118 -10)

Show changes

	rbtools/api/resource.py
	rbtools/commands/post.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

rbtools/commands/post.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Worth putting the mimetype in here?
```

Change Summary:

Add mimetype to debug log message.

Commits:

	Summary	ID
	Handle uploading source versions of binaries when needed. When a change involving binary files is uploaded that requires a parent diff, we need to upload both the modified and source versions of the binary file (since the server can't fetch the source version from the repository). This change handles that, with the new `source_file` parameter to the diff file attachments API. Testing Done: Uploaded changes to binary files that required a parent diff. Saw the correct version of the source file.	be2074f852432ebe140be0f96af725ff3bc11529
	Handle uploading source versions of binaries when needed. When a change involving binary files is uploaded that requires a parent diff, we need to upload both the modified and source versions of the binary file (since the server can't fetch the source version from the repository). This change handles that, with the new `source_file` parameter to the diff file attachments API. Testing Done: Uploaded changes to binary files that required a parent diff. Saw the correct version of the source file.	14e09be42208b81cb174732e192e95d2da443800

Diff:

Revision 3 (+120 -10)

Show changes

	rbtools/api/resource.py
	rbtools/commands/post.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-5.x (a5222e8)