Handle uploading source versions of binaries when needed.

Review Request #13608 — Created March 4, 2024 and submitted

Information

RBTools
release-5.x

Reviewers

When a change involving binary files is uploaded that requires a parent
diff, we need to upload both the modified and source versions of the
binary file (since the server can't fetch the source version from the
repository). This change handles that, with the new source_file
parameter to the diff file attachments API.

Uploaded changes to binary files that required a parent diff.
Saw the correct version of the source file.

Summary ID
Handle uploading source versions of binaries when needed.
When a change involving binary files is uploaded that requires a parent diff, we need to upload both the modified and source versions of the binary file (since the server can't fetch the source version from the repository). This change handles that, with the new `source_file` parameter to the diff file attachments API. Testing Done: Uploaded changes to binary files that required a parent diff. Saw the correct version of the source file.
14e09be42208b81cb174732e192e95d2da443800
Description From Last Updated

Can we make this keyword-only? (Ideally everything.)

chipx86chipx86

Missing version information. Also, this needs , optional.

chipx86chipx86

These should be typed.

chipx86chipx86

Can we show what these mimetypes are?

chipx86chipx86

Worth putting the mimetype in here?

chipx86chipx86
chipx86
  1. 
      
  2. rbtools/api/resource.py (Diff revision 1)
     
     
    Show all issues

    Can we make this keyword-only? (Ideally everything.)

  3. rbtools/api/resource.py (Diff revision 1)
     
     
     
    Show all issues

    Missing version information.

    Also, this needs , optional.

    1. This whole resource specialization is new.

  4. rbtools/commands/post.py (Diff revision 1)
     
     
     
     
    Show all issues

    These should be typed.

  5. rbtools/commands/post.py (Diff revision 1)
     
     
     
     
     
    Show all issues

    Can we show what these mimetypes are?

  6. 
      
david
maubin
  1. Ship It!
  2. 
      
chipx86
  1. 
      
  2. rbtools/commands/post.py (Diff revision 2)
     
     
    Show all issues

    Worth putting the mimetype in here?

  3. 
      
david
chipx86
  1. Ship It!
  2. 
      
david
Review request changed
Status:
Completed
Change Summary:
Pushed to release-5.x (a5222e8)