Add typing and clean up some code in the mercurial backend.

 






 

 


  Review Request #13601
  —
  Created March 4, 2024 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  david
 









 
 

  Review Board
 









 
 

  release-7.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
This change adds type hints throughout the mercurial implementation, and

cleans up some of the style and comments throughout.


While going through this code I realized that the check_repository

implementation was instantiating HgClient incorrectly with the local

site. I've changed it so that everywhere passes the local site name.

 








  


 
 

  
Ran unit tests.

 







 









 





  








 




 







   

    
    
Diff Revision 1


This is not the most recent revision of the diff. The latest diff is revision 2. See what's changed.

    

 

 

 

 
orig
1
2

 



    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    

     Add typing and clean up some code in the mercurial backend.
     
This change adds type hints throughout the mercurial implementation, and
cleans up some of the style and comments throughout.

While going through this code I realized that the `check_repository`
implementation was instantiating HgClient incorrectly with the local
site. I've changed it so that everywhere passes the local site name.

Testing Done:
Ran unit tests.

    

   
  		
  3d5b2cebdba222e898f525f70dbd470ae7b27424
  David Trowbridge
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/scmtools/hg.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/scmtools/tests/test_hg.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...