Summary

Add typing and clean up some code in the mercurial backend.

Review Request #13601 — Created March 4, 2024 and submitted April 1, 2024, 10:35 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-7.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This change adds type hints throughout the mercurial implementation, and
cleans up some of the style and comments throughout.

While going through this code I realized that the check_repository
implementation was instantiating HgClient incorrectly with the local
site. I've changed it so that everywhere passes the local site name.

Testing Done

Ran unit tests.

Commits

Summary	ID
Add typing and clean up some code in the mercurial backend. This change adds type hints throughout the mercurial implementation, and cleans up some of the style and comments throughout. While going through this code I realized that the `check_repository` implementation was instantiating HgClient incorrectly with the local site. I've changed it so that everywhere passes the local site name. Testing Done: Ran unit tests.	277e1685f09aa67de7d52d9a4975c2fb43e444a2

Summary

Add typing and clean up some code in the mercurial backend.

This change adds type hints throughout the mercurial implementation, and cleans up some of the style and comments throughout. While going through this code I realized that the `check_repository` implementation was instantiating HgClient incorrectly with the local site. I've changed it so that everywhere passes the local site name. Testing Done: Ran unit tests.

277e1685f09aa67de7d52d9a4975c2fb43e444a2

Issues

Description	From	Last Updated
Needs to be the full path to Revision. Same with FileLookupContext below.	chipx86	March 4, 2024, 2:38 p.m.
We can probably remove this bit, since it's more guidance for the usage/implementation of the function in the main docs.	chipx86	March 4, 2024, 2:38 p.m.
Let's add , unused	chipx86	March 4, 2024, 2:39 p.m.
This is more guidance to what the subclass's implementation should do. It should probably be updated to be more specific …	chipx86	March 4, 2024, 2:40 p.m.
Let's keep capitalizing as "Local Site", since this is a defined term and not just a site that is local.	chipx86	March 4, 2024, 2:40 p.m.
:command:	chipx86	March 4, 2024, 2:40 p.m.

flake8 passed.

JSHint passed.

reviewboard/scmtools/hg.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Needs to be the full path to Revision.
Same with FileLookupContext below.
```

reviewboard/scmtools/hg.py (Diff revision 1)

The issue has been resolved. Show all issues

We can probably remove this bit, since it's more guidance for the usage/implementation of the function in the main docs.

reviewboard/scmtools/hg.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Let's add , unused
```

reviewboard/scmtools/hg.py (Diff revision 1)

The issue has been resolved. Show all issues

This is more guidance to what the subclass's implementation should do. It should probably be updated to be more specific to this implementation.

reviewboard/scmtools/hg.py (Diff revision 1)

The issue has been resolved. Show all issues

Let's keep capitalizing as "Local Site", since this is a defined term and not just a site that is local.

reviewboard/scmtools/hg.py (Diff revision 1)
The issue has been resolved. Show all issues
```
:command:
```

Commits:

	Summary	ID
	Add typing and clean up some code in the mercurial backend. This change adds type hints throughout the mercurial implementation, and cleans up some of the style and comments throughout. While going through this code I realized that the `check_repository` implementation was instantiating HgClient incorrectly with the local site. I've changed it so that everywhere passes the local site name. Testing Done: Ran unit tests.	3d5b2cebdba222e898f525f70dbd470ae7b27424
	Add typing and clean up some code in the mercurial backend. This change adds type hints throughout the mercurial implementation, and cleans up some of the style and comments throughout. While going through this code I realized that the `check_repository` implementation was instantiating HgClient incorrectly with the local site. I've changed it so that everywhere passes the local site name. Testing Done: Ran unit tests.	277e1685f09aa67de7d52d9a4975c2fb43e444a2

Diff:

Revision 2 (+1080 -372)

Show changes

	reviewboard/scmtools/hg.py
	reviewboard/scmtools/tests/test_hg.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-7.x (2017b45)