Remove the last of code marked for removal in 4.0.

Review Request #13599 — Created March 1, 2024 and submitted — Latest diff uploaded

Information

RBTools
release-5.x

Reviewers

This removes the last of the stuff slated for removal in RBTools 4.0
(which we didn't actually remove in 4.0). The only silly thing here was
the submit_as argument to guess_existing_review_request, which had been
marked as required for 4.0 but we weren't actually passing in values
from most callsites.

  • Ran unit tests.
  • Did a bunch of stuff that required guessing the review request from
    rbt land, rbt post, and rbt stamp.

Diff Revision 1

This is not the most recent revision of the diff. The latest diff is revision 3. See what's changed.

orig
1
2
3

Commits

First Last Summary ID Author
Remove the last of code marked for removal in 4.0.
This removes the last of the stuff slated for removal in RBTools 4.0 (which we didn't actually remove in 4.0). The only silly thing here was the submit_as argument to guess_existing_review_request, which had been marked as required for 4.0 but we weren't actually passing in values from most callsites. Testing Done: - Ran unit tests. - Did a bunch of stuff that required guessing the review request from `rbt land`, `rbt post`, and `rbt stamp`.
076e3da6f84404bb8a209b412c263336c617d8fb David Trowbridge
rbtools/deprecation.py
rbtools/commands/land.py
rbtools/commands/post.py
rbtools/commands/stamp.py
rbtools/utils/review_request.py
Loading...