Summary

Remove the last of code marked for removal in 4.0.

Review Request #13599 — Created March 1, 2024 and submitted March 5, 2024, 8:23 a.m.

Information

Owner

david

Repository

RBTools

Branch

release-5.x

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

Testing Done


Ran unit tests.
Did a bunch of stuff that required guessing the review request from

rbt land, rbt post, and rbt stamp.

Commits

Summary	ID
Remove the last of code marked for removal in 4.0. This removes the last of the stuff slated for removal in RBTools 4.0 (which we didn't actually remove in 4.0). The only silly thing here was the submit_as argument to guess_existing_review_request, which had been marked as required for 4.0 but we weren't actually passing in values from most callsites. Testing Done: - Ran unit tests. - Did a bunch of stuff that required guessing the review request from `rbt land`, `rbt post`, and `rbt stamp`.	c24f091a3f69fd230179e8f0a5eae3a60083cdef

Summary

Remove the last of code marked for removal in 4.0.

This removes the last of the stuff slated for removal in RBTools 4.0 (which we didn't actually remove in 4.0). The only silly thing here was the submit_as argument to guess_existing_review_request, which had been marked as required for 4.0 but we weren't actually passing in values from most callsites. Testing Done: - Ran unit tests. - Did a bunch of stuff that required guessing the review request from `rbt land`, `rbt post`, and `rbt stamp`.

c24f091a3f69fd230179e8f0a5eae3a60083cdef

Issues

Description	From	Last Updated
undefined name 'Optional' Column: 22 Error code: F821	reviewbot	March 1, 2024, 3:30 p.m.
undefined name 'Optional' Column: 16 Error code: F821	reviewbot	March 1, 2024, 3:30 p.m.
undefined name 'Optional' Column: 31 Error code: F821	reviewbot	March 1, 2024, 3:30 p.m.
Since we're fetching each of these many times, and asserting on them, let's just pull them out into locals, do …	chipx86	March 4, 2024, 4 p.m.
Same applies here.	chipx86	March 4, 2024, 4:01 p.m.
Same applies here.	chipx86	March 4, 2024, 4:02 p.m.
Also, all arguments are now keyword-only.	chipx86	March 4, 2024, 4:02 p.m.
Also, keyword-only args.	chipx86	March 4, 2024, 4:03 p.m.

flake8 failed.

JSHint passed.

flake8

rbtools/commands/land.py (Diff revision 1)
The issue has been dropped. Show all issues
```
undefined name 'Optional'

Column: 22
Error code: F821
```
rbtools/commands/stamp.py (Diff revision 1)
The issue has been dropped. Show all issues
```
undefined name 'Optional'

Column: 16
Error code: F821
```
rbtools/commands/stamp.py (Diff revision 1)
The issue has been dropped. Show all issues
```
undefined name 'Optional'

Column: 31
Error code: F821
```

Commits:

	Summary	ID
	Remove the last of code marked for removal in 4.0. This removes the last of the stuff slated for removal in RBTools 4.0 (which we didn't actually remove in 4.0). The only silly thing here was the submit_as argument to guess_existing_review_request, which had been marked as required for 4.0 but we weren't actually passing in values from most callsites. Testing Done: - Ran unit tests. - Did a bunch of stuff that required guessing the review request from `rbt land`, `rbt post`, and `rbt stamp`.	076e3da6f84404bb8a209b412c263336c617d8fb
	Remove the last of code marked for removal in 4.0. This removes the last of the stuff slated for removal in RBTools 4.0 (which we didn't actually remove in 4.0). The only silly thing here was the submit_as argument to guess_existing_review_request, which had been marked as required for 4.0 but we weren't actually passing in values from most callsites. Testing Done: - Ran unit tests. - Did a bunch of stuff that required guessing the review request from `rbt land`, `rbt post`, and `rbt stamp`.	416017dddb81cd0718e75ba56a54e8e7280411c9

Diff:

Revision 2 (+324 -354)

Show changes

	rbtools/deprecation.py
	rbtools/commands/land.py
	rbtools/commands/post.py
	rbtools/commands/stamp.py
	rbtools/utils/review_request.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

rbtools/commands/land.py (Diff revision 2)

The issue has been resolved. Show all issues

Since we're fetching each of these many times, and asserting on them, let's just pull them out into locals, do the assert, and then use those below.

rbtools/commands/post.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Same applies here.
```
rbtools/commands/stamp.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Same applies here.
```
rbtools/utils/review_request.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Also, all arguments are now keyword-only.
```
rbtools/utils/review_request.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Also, keyword-only args.
```

Commits:

	Summary	ID
	Remove the last of code marked for removal in 4.0. This removes the last of the stuff slated for removal in RBTools 4.0 (which we didn't actually remove in 4.0). The only silly thing here was the submit_as argument to guess_existing_review_request, which had been marked as required for 4.0 but we weren't actually passing in values from most callsites. Testing Done: - Ran unit tests. - Did a bunch of stuff that required guessing the review request from `rbt land`, `rbt post`, and `rbt stamp`.	416017dddb81cd0718e75ba56a54e8e7280411c9
	Remove the last of code marked for removal in 4.0. This removes the last of the stuff slated for removal in RBTools 4.0 (which we didn't actually remove in 4.0). The only silly thing here was the submit_as argument to guess_existing_review_request, which had been marked as required for 4.0 but we weren't actually passing in values from most callsites. Testing Done: - Ran unit tests. - Did a bunch of stuff that required guessing the review request from `rbt land`, `rbt post`, and `rbt stamp`.	c24f091a3f69fd230179e8f0a5eae3a60083cdef

Diff:

Revision 3 (+398 -394)

Show changes

	rbtools/deprecation.py
	rbtools/commands/land.py
	rbtools/commands/post.py
	rbtools/commands/stamp.py
	rbtools/utils/review_request.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-5.x (d18ee9f)