Remove the last of code marked for removal in 4.0.

Review Request #13599 — Created March 1, 2024 and submitted

Information

RBTools
release-5.x

Reviewers

This removes the last of the stuff slated for removal in RBTools 4.0
(which we didn't actually remove in 4.0). The only silly thing here was
the submit_as argument to guess_existing_review_request, which had been
marked as required for 4.0 but we weren't actually passing in values
from most callsites.

  • Ran unit tests.
  • Did a bunch of stuff that required guessing the review request from
    rbt land, rbt post, and rbt stamp.
Summary ID
Remove the last of code marked for removal in 4.0.
This removes the last of the stuff slated for removal in RBTools 4.0 (which we didn't actually remove in 4.0). The only silly thing here was the submit_as argument to guess_existing_review_request, which had been marked as required for 4.0 but we weren't actually passing in values from most callsites. Testing Done: - Ran unit tests. - Did a bunch of stuff that required guessing the review request from `rbt land`, `rbt post`, and `rbt stamp`.
c24f091a3f69fd230179e8f0a5eae3a60083cdef
Description From Last Updated

undefined name 'Optional' Column: 22 Error code: F821

reviewbotreviewbot

undefined name 'Optional' Column: 16 Error code: F821

reviewbotreviewbot

undefined name 'Optional' Column: 31 Error code: F821

reviewbotreviewbot

Since we're fetching each of these many times, and asserting on them, let's just pull them out into locals, do …

chipx86chipx86

Same applies here.

chipx86chipx86

Same applies here.

chipx86chipx86

Also, all arguments are now keyword-only.

chipx86chipx86

Also, keyword-only args.

chipx86chipx86
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

david
chipx86
  1. 
      
  2. rbtools/commands/land.py (Diff revision 2)
     
     
     
     
    Show all issues

    Since we're fetching each of these many times, and asserting on them, let's just pull them out into locals, do the assert, and then use those below.

  3. rbtools/commands/post.py (Diff revision 2)
     
     
     
     
    Show all issues

    Same applies here.

  4. rbtools/commands/stamp.py (Diff revision 2)
     
     
     
     
    Show all issues

    Same applies here.

  5. rbtools/utils/review_request.py (Diff revision 2)
     
     
     
     
     
    Show all issues

    Also, all arguments are now keyword-only.

  6. rbtools/utils/review_request.py (Diff revision 2)
     
     
     
     
     
     
     
    Show all issues

    Also, keyword-only args.

  7. 
      
david
chipx86
  1. Ship It!
  2. 
      
david
Review request changed
Status:
Completed
Change Summary:
Pushed to release-5.x (d18ee9f)