Implement get_file_content APIs for Subversion.

Review Request #13594 — Created March 1, 2024 and submitted

Information

RBTools
release-5.x

Reviewers

This change implements the new get_file_content and get_file_size APIs
for Subversion.

This also adds --force to the diff command when we know the server is
modern enough to understand that. Without this, we have zero revision
information about any binary files.

  • Ran unit tests.
  • Posted a variety of changes with binary files, including changes in my
    working copy and committed revisions.
Summary ID
Implement get_file_content APIs for Subversion.
This change implements the new get_file_content and get_file_size APIs for Subversion. This also adds `--force` to the diff command when we know the server is modern enough to understand that. Without this, we have zero revision information about any binary files. Testing Done: - Ran unit tests. - Posted a variety of changes with binary files, including changes in my working copy and committed revisions.
a7f18370865e939ee6b7e6ffc2de4b8a86331adb
Description From Last Updated

Can you add unit tests? We really should be fleshing these out for any new APIs.

chipx86chipx86

This can use the standard execute chain pattern: return ( self._run_svn(...) .stdout_bytes .read() ) Same below.

chipx86chipx86
maubin
  1. Ship It!
  2. 
      
chipx86
  1. 
      
  2. Can you add unit tests? We really should be fleshing these out for any new APIs.

  3. 
      
david
chipx86
  1. 
      
  2. rbtools/clients/svn.py (Diff revision 2)
     
     
     

    This can use the standard execute chain pattern:

    return (
        self._run_svn(...)
        .stdout_bytes
        .read()
    )
    

    Same below.

  3. 
      
david
chipx86
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-5.x (a5c76aa)
Loading...