This change has been marked as completed.

Describe the completed change (optional):

Pushed to release-5.x (a5c76aa)

Summary

Implement get_file_content APIs for Subversion.

Review Request #13594 — Created March 1, 2024 and submitted 1 year, 2 months ago

Information

Owner

david*

Repository

RBTools

Branch

release-5.x

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description*

This change implements the new get_file_content and get_file_size APIs
for Subversion.

This also adds --force to the diff command when we know the server is
modern enough to understand that. Without this, we have zero revision
information about any binary files.

Testing Done


Ran unit tests.
Posted a variety of changes with binary files, including changes in my

  working copy and committed revisions.

Commits

Summary	ID
Implement get_file_content APIs for Subversion. This change implements the new get_file_content and get_file_size APIs for Subversion. This also adds `--force` to the diff command when we know the server is modern enough to understand that. Without this, we have zero revision information about any binary files. Testing Done: - Ran unit tests. - Posted a variety of changes with binary files, including changes in my working copy and committed revisions.	a7f18370865e939ee6b7e6ffc2de4b8a86331adb

Summary

Implement get_file_content APIs for Subversion.

This change implements the new get_file_content and get_file_size APIs for Subversion. This also adds `--force` to the diff command when we know the server is modern enough to understand that. Without this, we have zero revision information about any binary files. Testing Done: - Ran unit tests. - Posted a variety of changes with binary files, including changes in my working copy and committed revisions.

a7f18370865e939ee6b7e6ffc2de4b8a86331adb

Issues

Description	From	Last Updated
Can you add unit tests? We really should be fleshing these out for any new APIs.	chipx86	1 year, 3 months ago
This can use the standard execute chain pattern: return ( self._run_svn(...) .stdout_bytes .read() ) Same below.	chipx86	1 year, 2 months ago
There are no open issues

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

The issue has been resolved. Show all issues

Can you add unit tests? We really should be fleshing these out for any new APIs.

Change Summary:

Add unit tests.

Commits:

	Summary	ID
	Implement get_file_content APIs for Subversion. This change implements the new get_file_content and get_file_size APIs for Subversion. This also adds `--force` to the diff command when we know the server is modern enough to understand that. Without this, we have zero revision information about any binary files. Testing Done: - Ran unit tests. - Posted a variety of changes with binary files, including changes in my working copy and committed revisions.	e37868812857c7d8c6ded9490172b630b03cc709
	Implement get_file_content APIs for Subversion. This change implements the new get_file_content and get_file_size APIs for Subversion. This also adds `--force` to the diff command when we know the server is modern enough to understand that. Without this, we have zero revision information about any binary files. Testing Done: - Ran unit tests. - Posted a variety of changes with binary files, including changes in my working copy and committed revisions.	7acad3bd5973776cb50fd1b6535eac044ad51b20

Diff:

Revision 2 (+378)

Show changes

	rbtools/clients/svn.py
	rbtools/clients/tests/test_svn.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

rbtools/clients/svn.py (Diff revision 2)

The issue has been resolved. Show all issues

This can use the standard execute chain pattern:

return (
    self._run_svn(...)
    .stdout_bytes
    .read()
)


Same below.

Commits:

	Summary	ID
	Implement get_file_content APIs for Subversion. This change implements the new get_file_content and get_file_size APIs for Subversion. This also adds `--force` to the diff command when we know the server is modern enough to understand that. Without this, we have zero revision information about any binary files. Testing Done: - Ran unit tests. - Posted a variety of changes with binary files, including changes in my working copy and committed revisions.	7acad3bd5973776cb50fd1b6535eac044ad51b20
	Implement get_file_content APIs for Subversion. This change implements the new get_file_content and get_file_size APIs for Subversion. This also adds `--force` to the diff command when we know the server is modern enough to understand that. Without this, we have zero revision information about any binary files. Testing Done: - Ran unit tests. - Posted a variety of changes with binary files, including changes in my working copy and committed revisions.	a7f18370865e939ee6b7e6ffc2de4b8a86331adb

Diff:

Revision 3 (+390)

Show changes

	rbtools/clients/svn.py
	rbtools/clients/tests/test_svn.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-5.x (a5c76aa)