Summary

Implement get_file_content APIs for git.

Review Request #13592 — Created March 1, 2024 and submitted April 1, 2024, 3:17 p.m.

Information

Owner

david

Repository

RBTools

Branch

release-5.x

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

This change implements the necessary client APIs for uploading binary
files to diffs for the git client.

Testing Done

Posted a variety of changes including binary files against a git
repository.

Commits

Summary	ID
Implement get_file_content APIs for git. This change implements the necessary client APIs for uploading binary files to diffs for the git client. Testing Done: Posted a variety of changes including binary files against a git repository.	35ff7bc62c74d16c1fa2f9033710d3731bfbb623

Issues

Description	From	Last Updated
Can we sort these?	chipx86	March 4, 2024, 6:34 p.m.
This is fine, but just as a note, the format being used elsewhere for most of the run_process-based chains are: …	chipx86	March 4, 2024, 6:34 p.m.
local variable 'content' is assigned to but never used Column: 13 Error code: F841	reviewbot	March 18, 2024, 3:31 p.m.
local variable 'size' is assigned to but never used Column: 13 Error code: F841	reviewbot	March 18, 2024, 3:31 p.m.
This could use the chain pattern: return int( self._run_git(...) .stdout .read() )	chipx86	March 26, 2024, 3:53 p.m.

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

rbtools/clients/git.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Can we sort these?
```

rbtools/clients/git.py (Diff revision 1)

The issue has been resolved. Show all issues

This is fine, but just as a note, the format being used elsewhere for most of the run_process-based chains are:

return (
    self._run_git(...)
    .stdout_bytes
    .read()
)

Commits:

	Summary	ID
	Implement get_file_content APIs for git. This change implements the necessary client APIs for uploading binary files to diffs for the git client. Testing Done: Posted a variety of changes including binary files against a git repository.	1ec76ce9af2209247a1965109420c5f6fd5dace7
	Implement get_file_content APIs for git. This change implements the necessary client APIs for uploading binary files to diffs for the git client. Testing Done: Posted a variety of changes including binary files against a git repository.	fc3b60ee3221fc6270c99e3d14f15797034f7b2a

Diff:

Revision 2 (+124 -4)

Show changes

rbtools/clients/git.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Change Summary:

Added some unit tests, fixed exception class.

Commits:

	Summary	ID
	Implement get_file_content APIs for git. This change implements the necessary client APIs for uploading binary files to diffs for the git client. Testing Done: Posted a variety of changes including binary files against a git repository.	fc3b60ee3221fc6270c99e3d14f15797034f7b2a
	Implement get_file_content APIs for git. This change implements the necessary client APIs for uploading binary files to diffs for the git client. Testing Done: Posted a variety of changes including binary files against a git repository.	50f75ad84375cafdeffcf3072beabcf8bec25cf8

Diff:

Revision 3 (+238 -4)

Show changes

	rbtools/clients/git.py
	rbtools/clients/tests/test_git.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

rbtools/clients/tests/test_git.py (Diff revision 3)
The issue has been dropped. Show all issues
```
local variable 'content' is assigned to but never used

Column: 13
Error code: F841
```
rbtools/clients/tests/test_git.py (Diff revision 3)
The issue has been dropped. Show all issues
```
local variable 'size' is assigned to but never used

Column: 13
Error code: F841
```

Commits:

	Summary	ID
	Implement get_file_content APIs for git. This change implements the necessary client APIs for uploading binary files to diffs for the git client. Testing Done: Posted a variety of changes including binary files against a git repository.	50f75ad84375cafdeffcf3072beabcf8bec25cf8
	Implement get_file_content APIs for git. This change implements the necessary client APIs for uploading binary files to diffs for the git client. Testing Done: Posted a variety of changes including binary files against a git repository.	ceafc7b79ea4786f4f6b1a9ca51ae4fd09114312

Diff:

Revision 4 (+238 -4)

Show changes

	rbtools/clients/git.py
	rbtools/clients/tests/test_git.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

rbtools/clients/git.py (Diff revision 4)

The issue has been resolved. Show all issues

This could use the chain pattern:

return int(
    self._run_git(...)
    .stdout
    .read()
)

Commits:

	Summary	ID
	Implement get_file_content APIs for git. This change implements the necessary client APIs for uploading binary files to diffs for the git client. Testing Done: Posted a variety of changes including binary files against a git repository.	ceafc7b79ea4786f4f6b1a9ca51ae4fd09114312
	Implement get_file_content APIs for git. This change implements the necessary client APIs for uploading binary files to diffs for the git client. Testing Done: Posted a variety of changes including binary files against a git repository.	35ff7bc62c74d16c1fa2f9033710d3731bfbb623

Diff:

Revision 5 (+238 -4)

Show changes

	rbtools/clients/git.py
	rbtools/clients/tests/test_git.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-5.x (a5a3fd5)