Download original versions of binary files for diffs.

Review Request #13582 — Created Feb. 27, 2024 and submitted — Latest diff uploaded

Information

Review Board
release-7.x

Reviewers

When viewing a diff where we have a file attachment for the new version
of a binary file, this change will download the original file and create
a matching file attachment.

Created a file attachment for the new version of an image in a diff.
Opened the diff viewer and saw that the original file was downloaded,
stored in a file attachment, and the image review UI showed a diff in
the diff viewer.

Diff Revision 2 (Latest)

orig
1
2

Commits

First Last Summary ID Author
Download original versions of binary files for diffs.
When viewing a diff where we have a file attachment for the new version of a binary file, this change will download the original file and create a matching file attachment. Testing Done: Created a file attachment for the new version of an image in a diff. Opened the diff viewer and saw that the original file was downloaded, stored in a file attachment, and the image review UI showed a diff in the diff viewer.
d39db57538bc740f59268b05c0830b0b98c0f40f David Trowbridge
reviewboard/reviews/views/diff_fragments.py
Loading...