Summary

Download original versions of binary files for diffs.

Review Request #13582 — Created Feb. 27, 2024 and submitted March 5, 2024, 8:19 a.m.

Information

Owner

david

Repository

Review Board

Branch

release-7.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

When viewing a diff where we have a file attachment for the new version
of a binary file, this change will download the original file and create
a matching file attachment.

Testing Done

Created a file attachment for the new version of an image in a diff.
Opened the diff viewer and saw that the original file was downloaded,
stored in a file attachment, and the image review UI showed a diff in
the diff viewer.

Commits

Summary	ID
Download original versions of binary files for diffs. When viewing a diff where we have a file attachment for the new version of a binary file, this change will download the original file and create a matching file attachment. Testing Done: Created a file attachment for the new version of an image in a diff. Opened the diff viewer and saw that the original file was downloaded, stored in a file attachment, and the image review UI showed a diff in the diff viewer.	d39db57538bc740f59268b05c0830b0b98c0f40f

Summary

Download original versions of binary files for diffs.

When viewing a diff where we have a file attachment for the new version of a binary file, this change will download the original file and create a matching file attachment. Testing Done: Created a file attachment for the new version of an image in a diff. Opened the diff viewer and saw that the original file was downloaded, stored in a file attachment, and the image review UI showed a diff in the diff viewer.

d39db57538bc740f59268b05c0830b0b98c0f40f

Issues

Description	From	Last Updated
'django.template.Context' imported but unused Column: 1 Error code: F401	reviewbot	Feb. 27, 2024, 9:28 a.m.
local variable 'context' is assigned to but never used Column: 9 Error code: F841	reviewbot	Feb. 27, 2024, 9:28 a.m.
We should just import os.	chipx86	March 4, 2024, 7:35 p.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/reviews/views/diff_fragments.py (Diff revision 1)
The issue has been dropped. Show all issues
```
'django.template.Context' imported but unused

Column: 1
Error code: F401
```
reviewboard/reviews/views/diff_fragments.py (Diff revision 1)
The issue has been dropped. Show all issues
```
local variable 'context' is assigned to but never used

Column: 9
Error code: F841
```

Commits:

	Summary	ID
	Download original versions of binary files for diffs. When viewing a diff where we have a file attachment for the new version of a binary file, this change will download the original file and create a matching file attachment. Testing Done: Created a file attachment for the new version of an image in a diff. Opened the diff viewer and saw that the original file was downloaded, stored in a file attachment, and the image review UI showed a diff in the diff viewer.	c46f49f10edf5a829abc2ce11a156183ca99aa1c
	Download original versions of binary files for diffs. When viewing a diff where we have a file attachment for the new version of a binary file, this change will download the original file and create a matching file attachment. Testing Done: Created a file attachment for the new version of an image in a diff. Opened the diff viewer and saw that the original file was downloaded, stored in a file attachment, and the image review UI showed a diff in the diff viewer.	d39db57538bc740f59268b05c0830b0b98c0f40f

Diff:

Revision 2 (+176 -2)

Show changes

reviewboard/reviews/views/diff_fragments.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

reviewboard/reviews/views/diff_fragments.py (Diff revision 2)
The issue has been resolved. Show all issues
```
We should just import os.
```

Status:: Completed
Change Summary:: Pushed to release-7.x (8562e38)