Download original versions of binary files for diffs.

Review Request #13582 — Created Feb. 27, 2024 and submitted — Latest diff uploaded

Information

Review Board
release-7.x

Reviewers

When viewing a diff where we have a file attachment for the new version
of a binary file, this change will download the original file and create
a matching file attachment.

Created a file attachment for the new version of an image in a diff.
Opened the diff viewer and saw that the original file was downloaded,
stored in a file attachment, and the image review UI showed a diff in
the diff viewer.

Diff Revision 1

This is not the most recent revision of the diff. The latest diff is revision 2. See what's changed.

orig
1
2

Commits

First Last Summary ID Author
Download original versions of binary files for diffs.
When viewing a diff where we have a file attachment for the new version of a binary file, this change will download the original file and create a matching file attachment. Testing Done: Created a file attachment for the new version of an image in a diff. Opened the diff viewer and saw that the original file was downloaded, stored in a file attachment, and the image review UI showed a diff in the diff viewer.
c46f49f10edf5a829abc2ce11a156183ca99aa1c David Trowbridge
reviewboard/reviews/views/diff_fragments.py
Loading...