Add a max attachment size for diff file attachments.
Review Request #13579 — Created Feb. 27, 2024 and submitted
This change adds a configurable maximum attachment size for file
attachments which are connected to diffs. This works very much like the
configured maximum diff size.Our initial default is 10MB. This should be enough for most images and
documents. The limit can be changed in the diff settings page in the
admin site.At the moment this is enforced on the server side when attempting to
create the attachment. The limit is also included in the server
capabilities object so clients can make a decision about whether to
attempt to upload. While doing this I also added the max diff size to
the capabilities.
Ran unit tests.
Summary | ID |
---|---|
ed31774a6ad53cf972f2b10d5b0471766a264a51 |
Description | From | Last Updated |
---|---|---|
Extra comma added (will turn this into a tuple). |
chipx86 | |
Same here. |
chipx86 | |
Same here. |
chipx86 | |
Missing a "Version Added". Also make sure this ends up in the coderef index. |
chipx86 | |
Missing docs. |
chipx86 | |
Can we make this a keyword-only argument? |
chipx86 | |
Missing a return type. I think this (and keyword-only arguments) were covered in another change, but maybe that should be … |
chipx86 | |
Let's put these in alphabetical order. |
chipx86 | |
Let's put these in alphabetical order. |
chipx86 | |
Let's put these in alphabetical order. Mayb worth using .update()? Easier for maintenance. |
chipx86 | |
I'm trying to move more of these tests to do a full-on equality check of the response, to avoid missing … |
chipx86 |
-
-
reviewboard/admin/forms/diff_settings.py (Diff revision 1) Extra comma added (will turn this into a tuple).
-
-
-
reviewboard/attachments/errors.py (Diff revision 1) Missing a "Version Added".
Also make sure this ends up in the coderef index.
-
-
-
reviewboard/attachments/forms.py (Diff revision 1) Missing a return type.
I think this (and keyword-only arguments) were covered in another change, but maybe that should be addressed here and not in that one.
-
reviewboard/webapi/resources/diff_file_attachment.py (Diff revision 1) Let's put these in alphabetical order.
-
reviewboard/webapi/resources/draft_filediff.py (Diff revision 1) Let's put these in alphabetical order.
-
reviewboard/webapi/server_info.py (Diff revision 1) Let's put these in alphabetical order.
Mayb worth using
.update()
? Easier for maintenance. -
reviewboard/webapi/tests/test_draft_filediff.py (Diff revision 1) I'm trying to move more of these tests to do a full-on equality check of the response, to avoid missing things and to ensure things like sub-types of errors are caught. Can we switch that?
Commits: |
|
|||||||
---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+424 -24) |