Set comment diff_against_file_attachment to be a raw ID field in admin.

 






 

 


  Review Request #13577
  —
  Created Feb. 27, 2024 and submitted 

 




















 

  

   Information

  





 
 

  david
 









 
 

  Review Board
 









 
 

  release-7.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
In the admin UI, we had FileAttachmentComment.file_attachment correctly

set as a raw ID field, but the diff_against_file_attachment field was

not.

 








  


 
 

  
Looked at a file attachment comment for an attachment diff in the admin site.

 







 









 





  

 


 
 

  



 

  
   


    Summary
    ID

   

  
  

   


    

     

      Set comment diff_against_file_attachment to be a raw ID field in admin.
      
In the admin UI, we had `FileAttachmentComment.file_attachment` correctly
set as a raw ID field, but the `diff_against_file_attachment` field was
not.

Testing Done:
Looked at a file attachment comment for an attachment diff in the admin site.

     


    		
    7ac30469b47427184d669d357ab0443f12a00a60

   



  
 




 













 









 






  

 



















 




 




 














 





 

  

   




maubin




   

   







  

 



 

  


   

   

    
 
maubin


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




david




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Closed (submitted)

  
 




 
Change Summary:

 
Pushed to release-7.x (abb2a8f)





 


 










  

 









     

    

   

  

  

   
   Loading...