Summary

Make some layout tweaks to the two-up mode for image diffs.

Review Request #13575 — Created Feb. 27, 2024 and submitted March 5, 2024, 8:19 a.m.

Information

Owner

david

Repository

Review Board

Branch

release-7.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

The two-up mode was displaying the images as floating with the
vertical-align being the baseline, but this didn't match the way the
other diff modes aligned things (at the top). This changes the layout to
use flexbox to achieve the same layout but have things aligned at the
top of the container instead of the bottom.

Testing Done

Looked at an image diff.

Commits

Summary	ID
Make some layout tweaks to the two-up mode for image diffs. The two-up mode was displaying the images as floating with the vertical-align being the baseline, but this didn't match the way the other diff modes aligned things (at the top). This changes the layout to use flexbox to achieve the same layout but have things aligned at the top of the container instead of the bottom. Testing Done: Looked at an image diff.	bc285f1ee89a1fc0141a873005b620397b961b03

Summary

Make some layout tweaks to the two-up mode for image diffs.

The two-up mode was displaying the images as floating with the vertical-align being the baseline, but this didn't match the way the other diff modes aligned things (at the top). This changes the layout to use flexbox to achieve the same layout but have things aligned at the top of the container instead of the bottom. Testing Done: Looked at an image diff.

bc285f1ee89a1fc0141a873005b620397b961b03

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-7.x (a1effb3)