Summary

Add a function for getting the value of a server capability.

Review Request #13568 — Created Feb. 21, 2024 and submitted March 5, 2024, 8:23 a.m.

Information

Owner

david

Repository

RBTools

Branch

release-5.x

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

The capabilities returned by the server have traditionally been

booleans, but we're adding some more of other types (such as a list of

supported MIME types for review, and potentially some file size limits).

This change adds a new method to return the content of a capability

instead of just whether it's equal to True.

Testing Done

Used from another change.

Commits

Summary	ID
Add a function for getting the value of a server capability. The capabilities returned by the server have traditionally been booleans, but we're adding some more of other types (such as a list of supported MIME types for review, and potentially some file size limits). This change adds a new method to return the content of a capability instead of just whether it's equal to `True`. Testing Done: Used from another change.	6115491858ac7e112d5112f731bffe5552232137

Summary

Add a function for getting the value of a server capability.

The capabilities returned by the server have traditionally been booleans, but we're adding some more of other types (such as a list of supported MIME types for review, and potentially some file size limits). This change adds a new method to return the content of a capability instead of just whether it's equal to `True`. Testing Done: Used from another change.

6115491858ac7e112d5112f731bffe5552232137

Issues

Description	From	Last Updated
Can you add unit tests for the different cases? I want to flesh out RBTools tests where possible, and this …	chipx86	Feb. 27, 2024, 9:33 a.m.

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

The issue has been resolved. Show all issues

Can you add unit tests for the different cases? I want to flesh out RBTools tests where possible, and this is an important one to not regress.

Commits:

	Summary	ID
	Add a function for getting the value of a server capability. The capabilities returned by the server have traditionally been booleans, but we're adding some more of other types (such as a list of supported MIME types for review, and potentially some file size limits). This change adds a new method to return the content of a capability instead of just whether it's equal to `True`. Testing Done: Used from another change.	e33fb6360b29f10554bacee4207df26e8464fc2d
	Add a function for getting the value of a server capability. The capabilities returned by the server have traditionally been booleans, but we're adding some more of other types (such as a list of supported MIME types for review, and potentially some file size limits). This change adds a new method to return the content of a capability instead of just whether it's equal to `True`. Testing Done: Used from another change.	6115491858ac7e112d5112f731bffe5552232137

Diff:

Revision 2 (+96 -18)

Show changes

	rbtools/api/capabilities.py
	rbtools/api/tests/test_capabilities.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Status: Closed (submitted)

Change Summary:

Pushed to release-5.x (aa1eede)