Summary

Fix warnings and deprecations in tests.

Review Request #13566 — Created Feb. 21, 2024 and submitted Feb. 27, 2024, 9:47 a.m.

Information

Owner

david

Repository

RBTools

Branch

release-5.x

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

We had a handful of things in the RBTools that were hitting our own
deprecated code paths. This change cleans all of those up.

This change also adds a few things to our warnings ignore list, and
moves the entire pytest configuration into setup.cfg to match our other
codebases.

Testing Done

Ran unit tests. Saw everything run with no warnings.

Commits

Summary	ID
Fix warnings and deprecations in tests. We had a handful of things in the RBTools that were hitting our own deprecated code paths. This change cleans all of those up. This change also adds a few things to our warnings ignore list, and moves the entire pytest configuration into setup.cfg to match our other codebases. Testing Done: - Ran unit tests. Saw everything run with no warnings.	1fdd80910e9bd364f340435323c720f92f432359

Issues

Description	From	Last Updated
line too long (81 > 79 characters) Column: 80 Error code: E501	reviewbot	Feb. 21, 2024, 4:44 p.m.

flake8 failed.

JSHint passed.

flake8

rbtools/api/cache.py (Diff revision 1)
The issue has been resolved. Show all issues
```
line too long (81 > 79 characters)

Column: 80
Error code: E501
```

Commits:

	Summary	ID
	Fix warnings and deprecations in tests. We had a handful of things in the RBTools that were hitting our own deprecated code paths. This change cleans all of those up. This change also adds a few things to our warnings ignore list, and moves the entire pytest configuration into setup.cfg to match our other codebases. Testing Done: - Ran unit tests. Saw everything run with no warnings.	05906ed8ac983d7db75b7f9d413e6a02d8faf060
	Fix warnings and deprecations in tests. We had a handful of things in the RBTools that were hitting our own deprecated code paths. This change cleans all of those up. This change also adds a few things to our warnings ignore list, and moves the entire pytest configuration into setup.cfg to match our other codebases. Testing Done: - Ran unit tests. Saw everything run with no warnings.	1fdd80910e9bd364f340435323c720f92f432359

Diff:

Revision 2 (+94 -208)

Show changes

	pytest.ini
	setup.cfg
	rbtools/api/cache.py
	rbtools/api/request.py
	rbtools/api/tests/test_http_request.py
	rbtools/api/tests/test_resource.py
	rbtools/api/transport/sync.py
	rbtools/clients/tests/test_mercurial.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-5.x (baee915)

rbtools/api/cache.py (Diff revision 1)