Summary

Add a simple CommaSeparatedValuesField for DB models.

Review Request #13560 — Created Feb. 20, 2024 and submitted Feb. 27, 2024, 8:20 a.m.

Information

Owner

david

Repository

Djblets

Branch

release-5.x

Bugs

Depends On

Reviewers

Groups

djblets

People

Description

django-multiselectfield itself isn't very big, and of what it offers, we
don't actually use very much. This change adds a new field type to
Djblets to do the database serialization/deserialization to join and
split comma-separated values. It doesn't support the validation that
django-multiselectfield does, but we don't actually care about that
functionality.

Testing Done


Ran unit tests.
Used this in Review Board and tested the functionality of the

  WebHookTarget admin form.

Commits

Summary	ID
Add a simple CommaSeparatedValuesField for DB models. We're running into some trouble that the old django-multiselectfield project is unmaintained and does not support Django 4.x+. There's a third-party fork which has had some updates, but no releases of that that we can consume. django-multiselectfield itself isn't very big, and of what it offers, we don't actually use very much. This change adds a new field type to Djblets to do the database serialization/deserialization to join and split comma-separated values. It doesn't support the validation that django-multiselectfield does, but we don't actually care about that functionality. Testing Done: - Ran unit tests. - Used this in Review Board and tested the functionality of the WebHookTarget admin form.	e7c884574cff4811f23eb3f66acb84c4a92858d0

Summary

Add a simple CommaSeparatedValuesField for DB models.

We're running into some trouble that the old django-multiselectfield project is unmaintained and does not support Django 4.x+. There's a third-party fork which has had some updates, but no releases of that that we can consume. django-multiselectfield itself isn't very big, and of what it offers, we don't actually use very much. This change adds a new field type to Djblets to do the database serialization/deserialization to join and split comma-separated values. It doesn't support the validation that django-multiselectfield does, but we don't actually care about that functionality. Testing Done: - Ran unit tests. - Used this in Review Board and tested the functionality of the WebHookTarget admin form.

e7c884574cff4811f23eb3f66acb84c4a92858d0

Issues

Description	From	Last Updated
Missing type here and in the docstring.	maubin	Feb. 26, 2024, 9:06 a.m.
Leftover dev code.	maubin	Feb. 26, 2024, 9:06 a.m.

flake8 passed.

JSHint passed.

Change Summary:

Fix some deserialization problems.

Commits:

	Summary	ID
	Add a simple CommaSeparatedValuesField for DB models. We're running into some trouble that the old django-multiselectfield project is unmaintained and does not support Django 4.x+. There's a third-party fork which has had some updates, but no releases of that that we can consume. django-multiselectfield itself isn't very big, and of what it offers, we don't actually use very much. This change adds a new field type to Djblets to do the database serialization/deserialization to join and split comma-separated values. It doesn't support the validation that django-multiselectfield does, but we don't actually care about that functionality. Testing Done: - Ran unit tests. - Used this in Review Board and tested the functionality of the WebHookTarget admin form.	297ed52eb72fed98b6d4b4885f80bd31aec64a8c
	Add a simple CommaSeparatedValuesField for DB models. We're running into some trouble that the old django-multiselectfield project is unmaintained and does not support Django 4.x+. There's a third-party fork which has had some updates, but no releases of that that we can consume. django-multiselectfield itself isn't very big, and of what it offers, we don't actually use very much. This change adds a new field type to Djblets to do the database serialization/deserialization to join and split comma-separated values. It doesn't support the validation that django-multiselectfield does, but we don't actually care about that functionality. Testing Done: - Ran unit tests. - Used this in Review Board and tested the functionality of the WebHookTarget admin form.	fbc676d02586ff11aca50a6b4abe84c38dd04195

Diff:

Revision 2 (+366)

Show changes

	djblets/db/fields/__init__.py
	djblets/db/fields/comma_separated_values_field.py
	djblets/db/tests/test_comma_separated_values_field.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

djblets/db/fields/comma_separated_values_field.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Missing type here and in the docstring.
```
djblets/db/fields/comma_separated_values_field.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Leftover dev code.
```

Commits:

	Summary	ID
	Add a simple CommaSeparatedValuesField for DB models. We're running into some trouble that the old django-multiselectfield project is unmaintained and does not support Django 4.x+. There's a third-party fork which has had some updates, but no releases of that that we can consume. django-multiselectfield itself isn't very big, and of what it offers, we don't actually use very much. This change adds a new field type to Djblets to do the database serialization/deserialization to join and split comma-separated values. It doesn't support the validation that django-multiselectfield does, but we don't actually care about that functionality. Testing Done: - Ran unit tests. - Used this in Review Board and tested the functionality of the WebHookTarget admin form.	fbc676d02586ff11aca50a6b4abe84c38dd04195
	Add a simple CommaSeparatedValuesField for DB models. We're running into some trouble that the old django-multiselectfield project is unmaintained and does not support Django 4.x+. There's a third-party fork which has had some updates, but no releases of that that we can consume. django-multiselectfield itself isn't very big, and of what it offers, we don't actually use very much. This change adds a new field type to Djblets to do the database serialization/deserialization to join and split comma-separated values. It doesn't support the validation that django-multiselectfield does, but we don't actually care about that functionality. Testing Done: - Ran unit tests. - Used this in Review Board and tested the functionality of the WebHookTarget admin form.	e7c884574cff4811f23eb3f66acb84c4a92858d0

Diff:

Revision 3 (+366)

Show changes

	djblets/db/fields/__init__.py
	djblets/db/fields/comma_separated_values_field.py
	djblets/db/tests/test_comma_separated_values_field.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-5.x (4b8e068)