Summary

Add preparation for TypeScript 5.3 and Stage 3 decorators.

Review Request #13557 — Created Feb. 19, 2024 and submitted Feb. 19, 2024, 4:35 p.m.

Information

Owner

chipx86

Repository

Spina

Branch

master

Bugs

Depends On

Reviewers

Groups

beanbag-misc

People

Description

Stage 3 decorators are currently standard in TypeScript and Babel. We're

not able to use it in Spina just yet, but in preparation, we're now

adding the context argument to our decorator function to signal

support for Stage 3 decorators. It's made optional, allowing legacy

decorators to continue to work.
The decorators are also typed with <This, TBase>, which allows us to

return a proper type mixing in the decorated class.
There are also some documentation fixes around decorator arguments.

Testing Done

Unit tests pass with legacy decorators.

Commits

Summary	ID
Add preparation for Stage 3 decorators. Stage 3 decorators are currently standard in TypeScript and Babel. We're not able to use it in Spina just yet, but in preparation, we're now adding the `context` argument to our decorator function to signal support for Stage 3 decorators. It's made optional, allowing legacy decorators to continue to work.	9795845569d173d8ac4ec78a91e0ab1b52c4fd4c

flake8 passed.

JSHint passed.

Summary:

-	Add preparation for Stage 3 decorators.
+	Add preparation for TypeScript 5.3 and Stage 3 decorators.

Description:

		Stage 3 decorators are currently standard in TypeScript and Babel. We're
		not able to use it in Spina just yet, but in preparation, we're now
		adding the `context` argument to our decorator function to signal
		support for Stage 3 decorators. It's made optional, allowing legacy
		decorators to continue to work.

	+	The decorators are also typed with `<This, TBase>`, which allows us to
	+	return a proper type mixing in the decorated class.
	+
		There are also some documentation fixes around decorator arguments.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to master (166959c)