Summary

Add a flag to the FileDiff resource to query for only binary files.

Review Request #13542 — Created Feb. 16, 2024 and submitted Feb. 27, 2024, 8:24 a.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

In order for RBTools to upload binary files, we need to know which ones
are needed. This change adds a query parameter to the FileDiff list
resource that allows a caller to get only FileDiffs that are marked as
binary.

Testing Done


Ran unit tests.
Used the API and saw that I was given the correct results.

Commits

Summary	ID
Add a flag to the FileDiff resource to query for only binary files. In order for RBTools to upload binary files, we need to know which ones are needed. This change adds a query parameter to the FileDiff list resource that allows a caller to get only FileDiffs that are marked as binary. Testing Done: - Ran unit tests. - Used the API and saw that I was given the correct results.	a5164c8e3c34b9134523245cbf8f85a740c57c4a

Issues

Description	From	Last Updated
I feel like there's value in being able to do binary=False. Can we do: binary = request.GET.get('binary') if binary is …	chipx86	Feb. 19, 2024, 8:40 p.m.

flake8 passed.

JSHint passed.

reviewboard/webapi/resources/filediff.py (Diff revision 1)

The issue has been resolved. Show all issues

I feel like there's value in being able to do binary=False. Can we do:

binary = request.GET.get('binary')

if binary is not None:
    ...

And then unit tests for the default and False conditions.

Commits:

	Summary	ID
	Add a flag to the FileDiff resource to query for only binary files. In order for RBTools to upload binary files, we need to know which ones are needed. This change adds a query parameter to the FileDiff list resource that allows a caller to get only FileDiffs that are marked as binary. Testing Done: - Ran unit tests. - Used the API and saw that I was given the correct results.	1696b649175b65e1a862305eb47fc673ff0d210f
	Add a flag to the FileDiff resource to query for only binary files. In order for RBTools to upload binary files, we need to know which ones are needed. This change adds a query parameter to the FileDiff list resource that allows a caller to get only FileDiffs that are marked as binary. Testing Done: - Ran unit tests. - Used the API and saw that I was given the correct results.	a5164c8e3c34b9134523245cbf8f85a740c57c4a

Diff:

Revision 2 (+250 -6)

Show changes

	reviewboard/webapi/resources/filediff.py
	reviewboard/webapi/tests/test_filediff.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-7.x (f62ce72)