Add a flag to the FileDiff resource to query for only binary files.

Review Request #13542 — Created Feb. 16, 2024 and submitted

Information

Review Board
master

Reviewers

In order for RBTools to upload binary files, we need to know which ones
are needed. This change adds a query parameter to the FileDiff list
resource that allows a caller to get only FileDiffs that are marked as
binary.

  • Ran unit tests.
  • Used the API and saw that I was given the correct results.
Summary ID
Add a flag to the FileDiff resource to query for only binary files.
In order for RBTools to upload binary files, we need to know which ones are needed. This change adds a query parameter to the FileDiff list resource that allows a caller to get only FileDiffs that are marked as binary. Testing Done: - Ran unit tests. - Used the API and saw that I was given the correct results.
a5164c8e3c34b9134523245cbf8f85a740c57c4a
Description From Last Updated

I feel like there's value in being able to do binary=False. Can we do: binary = request.GET.get('binary') if binary is …

chipx86chipx86
chipx86
  1. 
      
  2. reviewboard/webapi/resources/filediff.py (Diff revision 1)
     
     
     
     
     

    I feel like there's value in being able to do binary=False. Can we do:

    binary = request.GET.get('binary')
    
    if binary is not None:
        ...
    

    And then unit tests for the default and False conditions.

  3. 
      
david
maubin
  1. Ship It!
  2. 
      
chipx86
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-7.x (f62ce72)
Loading...