Add supported review UI MIME types to the server info capabilities.

Review Request #13537 — Created Feb. 12, 2024 and submitted

Information

Review Board
master

Reviewers

In order for RBTools to make intelligent decisions about what binary
files to upload to the server, we're exposing a list of supported MIME
types to the server capablities blob. This is populated from the
registered ReviewUI classes, and then we add manually the MIME types
supported by Power Pack (in order to optimistically have the client
upload files, even if the feature isn't yet licensed).

  • Verified that the correct data was in the server info API response.
  • Ran unit tests.
Summary ID
Add supported review UI MIME types to the server info capabilities.
In order for RBTools to make intelligent decisions about what binary files to upload to the server, we're exposing a list of supported MIME types to the server capablities blob. This is populated from the registered ReviewUI classes, and then we add manually the MIME types supported by Power Pack (in order to optimistically have the client upload files, even if the feature isn't yet licensed). Testing Done: - Verified that the correct data was in the server info API response. - Ran unit tests.
8409bf815bbce1619eba16fc18f1ce5cfd74cbeb
Description From Last Updated

Can we order these alphabetically?

chipx86chipx86

line too long (84 > 79 characters) Column: 80 Error code: E501

reviewbotreviewbot

line too long (82 > 79 characters) Column: 80 Error code: E501

reviewbotreviewbot

We should store as sorted, in order to avoid potential differences in the ETag between requests/backend servers.

chipx86chipx86

line too long (84 > 79 characters) Column: 80 Error code: E501

reviewbotreviewbot

line too long (82 > 79 characters) Column: 80 Error code: E501

reviewbotreviewbot
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

maubin
  1. Ship It!
  2. 
      
chipx86
  1. 
      
  2. reviewboard/webapi/server_info.py (Diff revision 1)
     
     
     
     
     
     
     
     
     
     
     
     

    Can we order these alphabetically?

  3. reviewboard/webapi/server_info.py (Diff revision 1)
     
     

    We should store as sorted, in order to avoid potential differences in the ETag between requests/backend servers.

  4. 
      
david
Review request changed

Commits:

Summary ID
Add supported review UI MIME types to the server info capabilities.
In order for RBTools to make intelligent decisions about what binary files to upload to the server, we're exposing a list of supported MIME types to the server capablities blob. This is populated from the registered ReviewUI classes, and then we add manually the MIME types supported by Power Pack (in order to optimistically have the client upload files, even if the feature isn't yet licensed). Testing Done: - Verified that the correct data was in the server info API response. - Ran unit tests.
b0de041efd1a5bf055d0ab7bc9ee4f0bf20efc0a
Add supported review UI MIME types to the server info capabilities.
In order for RBTools to make intelligent decisions about what binary files to upload to the server, we're exposing a list of supported MIME types to the server capablities blob. This is populated from the registered ReviewUI classes, and then we add manually the MIME types supported by Power Pack (in order to optimistically have the client upload files, even if the feature isn't yet licensed). Testing Done: - Verified that the correct data was in the server info API response. - Ran unit tests.
8409bf815bbce1619eba16fc18f1ce5cfd74cbeb

Diff:

Revision 2 (+108)

Show changes

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

chipx86
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-7.x (2078a70)
Loading...