Summary

Add supported review UI MIME types to the server info capabilities.

Review Request #13537 — Created Feb. 12, 2024 and submitted Feb. 20, 2024, 8:42 a.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

In order for RBTools to make intelligent decisions about what binary
files to upload to the server, we're exposing a list of supported MIME
types to the server capablities blob. This is populated from the
registered ReviewUI classes, and then we add manually the MIME types
supported by Power Pack (in order to optimistically have the client
upload files, even if the feature isn't yet licensed).

Testing Done


Verified that the correct data was in the server info API response.
Ran unit tests.

Commits

Summary	ID
Add supported review UI MIME types to the server info capabilities. In order for RBTools to make intelligent decisions about what binary files to upload to the server, we're exposing a list of supported MIME types to the server capablities blob. This is populated from the registered ReviewUI classes, and then we add manually the MIME types supported by Power Pack (in order to optimistically have the client upload files, even if the feature isn't yet licensed). Testing Done: - Verified that the correct data was in the server info API response. - Ran unit tests.	8409bf815bbce1619eba16fc18f1ce5cfd74cbeb

Summary

Add supported review UI MIME types to the server info capabilities.

In order for RBTools to make intelligent decisions about what binary files to upload to the server, we're exposing a list of supported MIME types to the server capablities blob. This is populated from the registered ReviewUI classes, and then we add manually the MIME types supported by Power Pack (in order to optimistically have the client upload files, even if the feature isn't yet licensed). Testing Done: - Verified that the correct data was in the server info API response. - Ran unit tests.

8409bf815bbce1619eba16fc18f1ce5cfd74cbeb

Issues

Description	From	Last Updated
Can we order these alphabetically?	chipx86	Feb. 16, 2024, 9:49 a.m.
line too long (84 > 79 characters) Column: 80 Error code: E501	reviewbot	Feb. 12, 2024, 3:02 p.m.
line too long (82 > 79 characters) Column: 80 Error code: E501	reviewbot	Feb. 12, 2024, 3:02 p.m.
We should store as sorted, in order to avoid potential differences in the ETag between requests/backend servers.	chipx86	Feb. 16, 2024, 9:49 a.m.
line too long (84 > 79 characters) Column: 80 Error code: E501	reviewbot	Feb. 16, 2024, 10:02 a.m.
line too long (82 > 79 characters) Column: 80 Error code: E501	reviewbot	Feb. 16, 2024, 10:02 a.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/webapi/server_info.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line too long (84 > 79 characters)

Column: 80
Error code: E501
```
reviewboard/webapi/server_info.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line too long (82 > 79 characters)

Column: 80
Error code: E501
```

Ship it!

```
Ship It!
```

reviewboard/webapi/server_info.py (Diff revision 1)

The issue has been resolved. Show all issues

Can we order these alphabetically?

reviewboard/webapi/server_info.py (Diff revision 1)

The issue has been resolved. Show all issues

We should store as sorted, in order to avoid potential differences in the ETag between requests/backend servers.

Commits:

	Summary	ID
	Add supported review UI MIME types to the server info capabilities. In order for RBTools to make intelligent decisions about what binary files to upload to the server, we're exposing a list of supported MIME types to the server capablities blob. This is populated from the registered ReviewUI classes, and then we add manually the MIME types supported by Power Pack (in order to optimistically have the client upload files, even if the feature isn't yet licensed). Testing Done: - Verified that the correct data was in the server info API response. - Ran unit tests.	b0de041efd1a5bf055d0ab7bc9ee4f0bf20efc0a
	Add supported review UI MIME types to the server info capabilities. In order for RBTools to make intelligent decisions about what binary files to upload to the server, we're exposing a list of supported MIME types to the server capablities blob. This is populated from the registered ReviewUI classes, and then we add manually the MIME types supported by Power Pack (in order to optimistically have the client upload files, even if the feature isn't yet licensed). Testing Done: - Verified that the correct data was in the server info API response. - Ran unit tests.	8409bf815bbce1619eba16fc18f1ce5cfd74cbeb

Diff:

Revision 2 (+108)

Show changes

	reviewboard/webapi/server_info.py
	reviewboard/webapi/tests/test_server_info.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/webapi/server_info.py (Diff revision 2)
The issue has been dropped. Show all issues
```
line too long (84 > 79 characters)

Column: 80
Error code: E501
```
reviewboard/webapi/server_info.py (Diff revision 2)
The issue has been dropped. Show all issues
```
line too long (82 > 79 characters)

Column: 80
Error code: E501
```

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-7.x (2078a70)