Summary

Store Review UIs in a real registry.

Review Request #13536 — Created Feb. 12, 2024 and submitted Feb. 20, 2024, 8:42 a.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

We had a kind of registry-like pattern for Review UIs, where we had
methods for registering and unregistering, and then stored them in a
list. This change adds a real registry for the backend storage.

Testing Done

Ran unit tests.

Commits

Summary	ID
Store Review UIs in a real registry. We had a kind of registry-like pattern for Review UIs, where we had methods for registering and unregistering, and then stored them in a list. This change adds a real registry for the backend storage. Testing Done: Ran unit tests.	edc0cb7b51fa20679df54bbe14d74f02f56f4271

Issues

Description	From	Last Updated
Missing docs with Version Added.	chipx86	Feb. 16, 2024, 9:47 a.m.
Should be separated with a blank line (ideally, import would be at the top of the function). If we move …	chipx86	Feb. 16, 2024, 9:47 a.m.
Should use Type for now, until we deprecate some older versions of Python. This is important because The type[...] actually …	chipx86	Feb. 16, 2024, 9:45 a.m.
We could use an f-string here.	chipx86	Feb. 16, 2024, 9:46 a.m.

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

reviewboard/reviews/ui/__init__.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Missing docs with Version Added.
```

reviewboard/reviews/ui/base.py (Diff revision 1)

The issue has been resolved. Show all issues

Should be separated with a blank line (ideally, import would be at the top of the function).
If we move the registry import into registry.py, and forward that in reviewboard.reviews.ui, there won't even be a need for this in-function import. We're a bit inconsistent today in our pattern here.
This comment applies to all following imports.

reviewboard/reviews/ui/registry.py (Diff revision 1)

The issue has been resolved. Show all issues

Should use Type for now, until we deprecate some older versions of Python.

This is important because The type[...] actually gets executed by Python, and will fail if type doesn't support generics.

reviewboard/reviews/ui/registry.py (Diff revision 1)
The issue has been resolved. Show all issues
```
We could use an f-string here.
```

Commits:

	Summary	ID
	Store Review UIs in a real registry. We had a kind of registry-like pattern for Review UIs, where we had methods for registering and unregistering, and then stored them in a list. This change adds a real registry for the backend storage. Testing Done: Ran unit tests.	d036dd57a3a600f2e9132211afc56b6f20ab8092
	Store Review UIs in a real registry. We had a kind of registry-like pattern for Review UIs, where we had methods for registering and unregistering, and then stored them in a list. This change adds a real registry for the backend storage. Testing Done: Ran unit tests.	edc0cb7b51fa20679df54bbe14d74f02f56f4271

Diff:

Revision 2 (+146 -50)

Show changes

	reviewboard/reviews/ui/__init__.py
	reviewboard/reviews/ui/base.py
	reviewboard/reviews/ui/registry.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-7.x (3ae4307)