Convert comment block models to TypeScript/spina.

 






 

 


  Review Request #13526
  —
  Created Feb. 6, 2024 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  david
 









 
 

  Review Board
 









 
 

  master
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
This change converts the comment block models used in Review UI

frontends to TypeScript.

 








  


 
 

  
    

  • Ran js-tests.
    • 

  • Verified that adding comments on various file attachments still worked
    
  correctly.
    • 


 







 









 





  








 




 







   

    
    
Diff Revision 2 (Latest)



    

 

 

 

 
orig
1
2

 



    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    

     Convert comment block models to TypeScript/spina.
     
This change converts the comment block models used in Review UI
frontends to TypeScript.

Testing Done:
- Ran js-tests.
- Verified that adding comments on various file attachments still worked
  correctly.

Reviewed at https://reviews.reviewboard.org/r/13526/

    

   
  		
  27593b4ab1f00ec0fe352bace0c1bfc2cca273c5
  David Trowbridge
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/staticbundles.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/diffviewer/models/diffCommentBlockModel.es6.js
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/models/textBasedCommentBlockModel.es6.js
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/reviews/index.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/models/abstractCommentBlockModel.es6.js
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/reviews/models/diffCommentBlockModel.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/models/fileAttachmentCommentBlockModel.es6.js
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/models/regionCommentBlockModel.es6.js
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/models/screenshotCommentBlockModel.es6.js
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/reviews/models/textCommentBlockModel.ts
     
    

   
  

 










     

    

   

  

  

   
   Loading...