Convert comment block models to TypeScript/spina.

Review Request #13526 — Created Feb. 6, 2024 and submitted

Information

Review Board
master

Reviewers

This change converts the comment block models used in Review UI
frontends to TypeScript.

  • Ran js-tests.
  • Verified that adding comments on various file attachments still worked
    correctly.
Summary ID
Convert comment block models to TypeScript/spina.
This change converts the comment block models used in Review UI frontends to TypeScript. Testing Done: - Ran js-tests. - Verified that adding comments on various file attachments still worked correctly. Reviewed at https://reviews.reviewboard.org/r/13526/
27593b4ab1f00ec0fe352bace0c1bfc2cca273c5
Description From Last Updated

Something we don't do enough, but should, is say when we want to allow null, using BaseComment | null. This …

chipx86chipx86

Do we have an explicit interface of attributes we can take?

chipx86chipx86

In these cases, what do you think about just not indenting extends?

chipx86chipx86

Two blank lines here.

chipx86chipx86
maubin
  1. Ship It!
  2. 
      
chipx86
  1. 
      
  2. Something we don't do enough, but should, is say when we want to allow null, using BaseComment | null.

    This is more a for-future-consideration comment. If we were consistent at this, we could enable even safer type checking.

    This would also be useful for the get*Warning() methods below.

  3. Do we have an explicit interface of attributes we can take?

  4. In these cases, what do you think about just not indenting extends?

  5. 
      
david
chipx86
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-7.x (41c9d64)
Loading...