Summary

Convert comment block models to TypeScript/spina.

Review Request #13526 — Created Feb. 6, 2024 and submitted Feb. 20, 2024, 8:42 a.m.

Owner

Repository

Review Board

Branch

master

Bugs

Depends On

Groups

People

Description

This change converts the comment block models used in Review UI
frontends to TypeScript.

Testing Done


Ran js-tests.
Verified that adding comments on various file attachments still worked

  correctly.

Commits

Summary	ID
Convert comment block models to TypeScript/spina. This change converts the comment block models used in Review UI frontends to TypeScript. Testing Done: - Ran js-tests. - Verified that adding comments on various file attachments still worked correctly. Reviewed at https://reviews.reviewboard.org/r/13526/	27593b4ab1f00ec0fe352bace0c1bfc2cca273c5

Issues

Description	From	Last Updated
Something we don't do enough, but should, is say when we want to allow null, using BaseComment \| null. This …	chipx86	Feb. 15, 2024, 7:28 p.m.
Do we have an explicit interface of attributes we can take?	chipx86	Feb. 15, 2024, 7:29 p.m.
In these cases, what do you think about just not indenting extends?	chipx86	Feb. 15, 2024, 7:30 p.m.
Two blank lines here.	chipx86	Feb. 15, 2024, 7:30 p.m.

flake8 passed.

JSHint passed.

Ship it!

reviewboard/static/rb/js/reviews/models/abstractCommentBlockModel.ts (Diff revision 1)

The issue has been resolved. Show all issues

Something we don't do enough, but should, is say when we want to allow null, using BaseComment | null.

This is more a for-future-consideration comment. If we were consistent at this, we could enable even safer type checking.

This would also be useful for the get*Warning() methods below.

reviewboard/static/rb/js/reviews/models/abstractCommentBlockModel.ts (Diff revision 1)
The issue has been resolved. Show all issues
```
Do we have an explicit interface of attributes we can take?
```
reviewboard/static/rb/js/reviews/models/fileAttachmentCommentBlockModel.ts (Diff revision 1)
The issue has been resolved. Show all issues
```
In these cases, what do you think about just not indenting extends?
```
1. david Feb. 15, 2024, 7:33 p.m.
  Sure.
reviewboard/static/rb/js/reviews/models/fileAttachmentCommentBlockModel.ts (Diff revision 1)
The issue has been resolved. Show all issues
```
Two blank lines here.
```

	Summary	ID
	Convert comment block models to TypeScript/spina. This change converts the comment block models used in Review UI frontends to TypeScript. Testing Done: - Ran js-tests. - Verified that adding comments on various file attachments still worked correctly.	223f3baa0bc1d76269328cc44c0f39764ec8db24
	Convert comment block models to TypeScript/spina. This change converts the comment block models used in Review UI frontends to TypeScript. Testing Done: - Ran js-tests. - Verified that adding comments on various file attachments still worked correctly. Reviewed at https://reviews.reviewboard.org/r/13526/	27593b4ab1f00ec0fe352bace0c1bfc2cca273c5

Revision 2 (+1068 -612)

	reviewboard/staticbundles.py
	reviewboard/static/rb/js/diffviewer/models/diffCommentBlockModel.es6.js
	reviewboard/static/rb/js/models/textBasedCommentBlockModel.es6.js
	reviewboard/static/rb/js/reviews/index.ts
	reviewboard/static/rb/js/models/abstractCommentBlockModel.es6.js
	reviewboard/static/rb/js/reviews/models/diffCommentBlockModel.ts
	reviewboard/static/rb/js/models/fileAttachmentCommentBlockModel.es6.js
	reviewboard/static/rb/js/models/regionCommentBlockModel.es6.js
	2 more

flake8 passed.

JSHint passed.

Ship it!

Pushed to release-7.x (41c9d64)