Get rid of duplicate prototypeAttrs definitions.

 






 

 


  Review Request #13519
  —
  Created Feb. 5, 2024 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  david
 









 
 

  Review Board
 









 
 

  master
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
Spina had a bug where prototypeAttrs weren't being correctly

inherited, so in several cases we had to duplicate entries in

subclasses. This bug has been fixed, so we can now get rid of those

duplicates.

 








  


 
 

  
Ran js-tests.

 







 









 





  








 




 







   

    
    
Diff Revision 1 (Latest)



    

    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    

     Get rid of duplicate prototypeAttrs definitions.
     
Spina had a bug where `prototypeAttrs` weren't being correctly
inherited, so in several cases we had to duplicate entries in
subclasses. This bug has been fixed, so we can now get rid of those
duplicates.

Testing Done:
Ran js-tests.

    

   
  		
  86b758fcb7ae0e2f3d4454fbb1725f5cde91e952
  David Trowbridge
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/static/rb/js/common/resources/models/draftFileAttachmentModel.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/common/resources/models/draftReviewModel.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/common/resources/models/fileAttachmentModel.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/common/resources/models/reviewModel.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/common/resources/models/reviewReplyModel.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/reviews/views/reviewRequestEditorView.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/reviews/views/reviewRequestFieldViews.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/reviews/views/reviewablePageView.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/ui/views/inlineEditorView.ts
     
    

   
  

 










     

    

   

  

  

   
   Loading...