Summary

Get rid of duplicate prototypeAttrs definitions.

Review Request #13519 — Created Feb. 5, 2024 and submitted March 5, 2024, 8:20 a.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Spina had a bug where prototypeAttrs weren't being correctly
inherited, so in several cases we had to duplicate entries in
subclasses. This bug has been fixed, so we can now get rid of those
duplicates.

Testing Done

Ran js-tests.

Commits

Summary	ID
Get rid of duplicate prototypeAttrs definitions. Spina had a bug where `prototypeAttrs` weren't being correctly inherited, so in several cases we had to duplicate entries in subclasses. This bug has been fixed, so we can now get rid of those duplicates. Testing Done: Ran js-tests.	86b758fcb7ae0e2f3d4454fbb1725f5cde91e952

flake8 passed.

JSHint passed.

Expand All
Collapse All

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Review Board 7.0 alpha 0 (dev)

Get rid of duplicate prototypeAttrs definitions.

Information

Reviewers

Status: Closed (submitted)