flake8
passed.
JSHint
passed.
Convert RB.ReviewRequest model to TypeScript/spina.
Review Request #13516 — Created Feb. 1, 2024 and submitted
This change converts the ReviewRequest resource model to TypeScript.
While I was updating this, I also got rid of the deprecated callbacks
style for its async methods.
Ran js-tests.
| Summary | ID |
|---|---|
| c7da1a1c69cc78cd43ef36ebbbcce4d5249994c4 |
| Description | From | Last Updated |
|---|---|---|
|
Add "Args" doc section. |
 maubin
|
|
|
Surround the states in double backticks. |
maubin
|
|
|
Similar to the comment I posted on /r/13515/, I'm wondering if we gain anything by making these enums instead. |
maubin
|
|
|
Need to update the docs since we changed the argument name from type to updateType. Should also probably add a … |
maubin
|
|
|
Missing return type. |
maubin
|
-
-
reviewboard/static/rb/js/common/resources/models/baseResourceModel.ts (Diff revision 1) Add "Args" doc section.
-
reviewboard/static/rb/js/common/resources/models/reviewRequestModel.ts (Diff revision 1) Surround the states in double backticks.
-
reviewboard/static/rb/js/common/resources/models/reviewRequestModel.ts (Diff revision 1) Similar to the comment I posted on /r/13515/, I'm wondering if we gain anything by making these enums instead.
-
reviewboard/static/rb/js/common/resources/models/reviewRequestModel.ts (Diff revision 1) Need to update the docs since we changed the argument name from
typetoupdateType. Should also probably add aVersion Changed. -
reviewboard/static/rb/js/common/resources/models/reviewRequestModel.ts (Diff revision 1) Missing return type.
Commits: |
|
|||||||
|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+884 -602) |
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.