This change has been marked as completed.

Describe the completed change (optional):

Summary

Convert RB.ReviewRequest model to TypeScript/spina.

Review Request #13516 — Created Feb. 1, 2024 and submitted 1 year, 2 months ago

Information

Owner

david*

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description*

This change converts the ReviewRequest resource model to TypeScript.
While I was updating this, I also got rid of the deprecated callbacks
style for its async methods.

Testing Done

Ran js-tests.

Commits

Summary	ID
Convert RB.ReviewRequest model to TypeScript/spina. This change converts the ReviewRequest resource model to TypeScript. While I was updating this, I also got rid of the deprecated callbacks style for its async methods. Testing Done: Ran js-tests.	c7da1a1c69cc78cd43ef36ebbbcce4d5249994c4

Issues

Description	From	Last Updated
Add "Args" doc section.	maubin	1 year, 2 months ago
Surround the states in double backticks.	maubin	1 year, 2 months ago
Similar to the comment I posted on /r/13515/, I'm wondering if we gain anything by making these enums instead.	maubin	1 year, 2 months ago
Need to update the docs since we changed the argument name from type to updateType. Should also probably add a …	maubin	1 year, 2 months ago
Missing return type.	maubin	1 year, 2 months ago
There are no open issues

flake8 passed.

JSHint passed.

reviewboard/static/rb/js/common/resources/models/baseResourceModel.ts (Diff revision 1)

The issue has been resolved. Show all issues

Add "Args" doc section.

reviewboard/static/rb/js/common/resources/models/reviewRequestModel.ts (Diff revision 1)

The issue has been resolved. Show all issues

Surround the states in double backticks.

reviewboard/static/rb/js/common/resources/models/reviewRequestModel.ts (Diff revision 1)

The issue has been dropped. Show all issues

Similar to the comment I posted on /r/13515/, I'm wondering if we gain anything by making these enums instead.

david 1 year, 2 months ago

Would be nice but I don't think it's worth breaking compat for that.

reviewboard/static/rb/js/common/resources/models/reviewRequestModel.ts (Diff revision 1)

The issue has been dropped. Show all issues

Need to update the docs since we changed the argument name from type to updateType. Should also probably add a Version Changed.

david 1 year, 2 months ago

Given that JS only really has positional arguments, there's no change from the consumer's perspective.

reviewboard/static/rb/js/common/resources/models/reviewRequestModel.ts (Diff revision 1)
The issue has been resolved. Show all issues
```
Missing return type.
```

Commits:

	Summary	ID
	Convert RB.ReviewRequest model to TypeScript/spina. This change converts the ReviewRequest resource model to TypeScript. While I was updating this, I also got rid of the deprecated callbacks style for its async methods. Testing Done: Ran js-tests.	d9cf86a7129c06a63d33e496bb82f25a887198c1
	Convert RB.ReviewRequest model to TypeScript/spina. This change converts the ReviewRequest resource model to TypeScript. While I was updating this, I also got rid of the deprecated callbacks style for its async methods. Testing Done: Ran js-tests.	c7da1a1c69cc78cd43ef36ebbbcce4d5249994c4

Diff:

Revision 2 (+884 -602)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/rb/js/common/models/userSessionModel.ts
	reviewboard/static/rb/js/common/resources/index.ts
	reviewboard/static/rb/js/common/resources/collections/tests/resourceCollectionTests.ts
	reviewboard/static/rb/js/common/resources/models/baseResourceModel.ts
	reviewboard/static/rb/js/resources/models/reviewRequestModel.es6.js
	reviewboard/static/rb/js/common/resources/models/tests/index.ts
	reviewboard/static/rb/js/common/resources/models/tests/reviewModelTests.ts
	21 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed