Convert RB.BaseComment to TypeScript/spina.

Review Request #13515 — Created Feb. 1, 2024 and submitted

Information

Review Board
master

Reviewers

This change converts our BaseComment model over to TypeScript.

Ran js-tests.

Summary ID
Convert RB.BaseComment to TypeScript/spina.
This change converts our BaseComment model over to TypeScript. Testing Done: Ran js-tests.
c1f08b97e5be66c2360a9c38d139af9b53b050e3
Description From Last Updated

Is it better to make these an enum instead of class attributes?

maubinmaubin

Surround true in double backticks.

maubinmaubin

Missing return type.

maubinmaubin
maubin
  1. 
      
  2. Is it better to make these an enum instead of class attributes?

    1. It probably would be but that would break API compat.

  3. Surround true in double backticks.

  4. 
      
david
maubin
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Loading...