Summary

Convert RB.BaseComment to TypeScript/spina.

Review Request #13515 — Created Feb. 1, 2024 and submitted Feb. 12, 2024, 9:53 a.m.

Owner

Repository

Review Board

Branch

master

Bugs

Depends On

Groups

People

Description

This change converts our BaseComment model over to TypeScript.

Testing Done

Ran js-tests.

Commits

Summary	ID
Convert RB.BaseComment to TypeScript/spina. This change converts our BaseComment model over to TypeScript. Testing Done: Ran js-tests.	c1f08b97e5be66c2360a9c38d139af9b53b050e3

Issues

Description	From	Last Updated
Is it better to make these an enum instead of class attributes?	maubin	Feb. 5, 2024, 8:37 a.m.
Surround true in double backticks.	maubin	Feb. 5, 2024, 8:35 a.m.
Missing return type.	maubin	Feb. 5, 2024, 8:35 a.m.

flake8 passed.

JSHint passed.

reviewboard/static/rb/js/common/resources/models/baseCommentModel.ts (Diff revision 1)

The issue has been dropped. Show all issues

Is it better to make these an enum instead of class attributes?

It probably would be but that would break API compat.

reviewboard/static/rb/js/common/resources/models/baseCommentModel.ts (Diff revision 1)
The issue has been resolved. Show all issues
```
Surround true in double backticks.
```
reviewboard/static/rb/js/common/resources/models/baseCommentModel.ts (Diff revision 1)
The issue has been resolved. Show all issues
```
Missing return type.
```

Commits:

	Summary	ID
	Convert RB.BaseComment to TypeScript/spina. This change converts our BaseComment model over to TypeScript. Testing Done: Ran js-tests.	7e38e876088489fa915c22d150aa6c917512401d
	Convert RB.BaseComment to TypeScript/spina. This change converts our BaseComment model over to TypeScript. Testing Done: Ran js-tests.	c1f08b97e5be66c2360a9c38d139af9b53b050e3

Diff:

Revision 2 (+744 -556)

	reviewboard/staticbundles.py
	reviewboard/static/rb/js/common/resources/index.ts
	reviewboard/static/rb/js/common/resources/models/baseCommentModel.ts
	reviewboard/static/rb/js/common/resources/models/baseResourceModel.ts
	reviewboard/static/rb/js/resources/models/tests/baseCommentModelTests.es6.js
	reviewboard/static/rb/js/common/resources/models/tests/baseResourceModelTests.ts
	reviewboard/static/rb/js/common/resources/models/tests/index.ts
	reviewboard/static/rb/js/resources/models/baseCommentModel.es6.js
	3 more

flake8 passed.

JSHint passed.

Ship it!