Summary

Add support for rollup.config.mjs and rollup.config.ts files.

Review Request #13510 — Created Jan. 25, 2024 and submitted March 9, 2024, 2:36 a.m.

Information

Owner

chipx86

Repository

Djblets

Branch

release-4.x

Bugs

Depends On

Reviewers

Groups

djblets

People

Description

This enhances RollupCompiler to explicitly look for .mjs and .ts
variants of the Rollup configuration files, and to use the correct
configuration arguments for each file type. This will give projects a
lot more flexibility in how they set up and even split up their Rollup
bundling.

It also checks for other common JavaScript configuration files
(babel.config.json and tsconfig.json) to try to calculate the top of
the tree.

Testing Done

Temporarily changed Review Board to use both .mjs and .ts files,
and verified that the right build configuration was used for each.

Commits

Summary	ID
Add support for rollup.config.mjs and rollup.config.ts files. This enhances `RollupCompiler` to explicitly look for `.mjs` and `.ts` variants of the Rollup configuration files, and to use the correct configuration arguments for each file type. This will give projects a lot more flexibility in how they set up and even split up their Rollup bundling. It also checks for other common JavaScript configuration files (`babel.config.json` and `tsconfig.json`) to try to calculate the top of the tree.	e32c44bd3c06d5fdc815c1d1fa1fc347209b64e2

Summary

Add support for rollup.config.mjs and rollup.config.ts files.

This enhances `RollupCompiler` to explicitly look for `.mjs` and `.ts` variants of the Rollup configuration files, and to use the correct configuration arguments for each file type. This will give projects a lot more flexibility in how they set up and even split up their Rollup bundling. It also checks for other common JavaScript configuration files (`babel.config.json` and `tsconfig.json`) to try to calculate the top of the tree.

e32c44bd3c06d5fdc815c1d1fa1fc347209b64e2

flake8 passed.

JSHint passed.

Change Summary:

Fixed logic that skipped too early and failed to traverse up at the right time.

Commits:

	Summary	ID
	Add support for rollup.config.mjs and rollup.config.ts files. This enhances `RollupCompiler` to explicitly look for `.mjs` and `.ts` variants of the Rollup configuration files, and to use the correct configuration arguments for each file type. This will give projects a lot more flexibility in how they set up and even split up their Rollup bundling. It also checks for other common JavaScript configuration files (`babel.config.json` and `tsconfig.json`) to try to calculate the top of the tree.	5addebc6300255d21b4cc532d553494586b3acc4
	Add support for rollup.config.mjs and rollup.config.ts files. This enhances `RollupCompiler` to explicitly look for `.mjs` and `.ts` variants of the Rollup configuration files, and to use the correct configuration arguments for each file type. This will give projects a lot more flexibility in how they set up and even split up their Rollup bundling. It also checks for other common JavaScript configuration files (`babel.config.json` and `tsconfig.json`) to try to calculate the top of the tree.	e32c44bd3c06d5fdc815c1d1fa1fc347209b64e2

Diff:

Revision 2 (+104 -28)

Show changes

djblets/pipeline/compilers/rollup.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-4.x (3fc9836)