Summary

Remove caching for HideActionHook results.

Review Request #13509 — Created Jan. 23, 2024 and submitted Feb. 7, 2024, 9:42 a.m.

Information

Owner

david

Repository

Review Board

Branch

release-6.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

The action implementation was caching the result of evaluating all of
the registered HideActionHook instances, but that ends up potentially
giving bad results. If an extension is being enabled or disabled, the
cached value can be incorrect. This is particularly noticable in the
devserver, but could affect production deployments too.

Testing Done

Ran unit tests.

Commits

Summary	ID
Remove caching for HideActionHook results. The action implementation was caching the result of evaluating all of the registered HideActionHook instances, but that ends up potentially giving bad results. If an extension is being enabled or disabled, the cached value can be incorrect. This is particularly noticable in the devserver, but could affect production deployments too. Testing Done: Ran unit tests.	f88bd104c7d691b5f645e973d6c971eca9370e0f

Summary

Remove caching for HideActionHook results.

The action implementation was caching the result of evaluating all of the registered HideActionHook instances, but that ends up potentially giving bad results. If an extension is being enabled or disabled, the cached value can be incorrect. This is particularly noticable in the devserver, but could affect production deployments too. Testing Done: Ran unit tests.

f88bd104c7d691b5f645e973d6c971eca9370e0f

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-6.x (52d18b7)