Switch a lot of conditional behavior over from settings.DEBUG to PRODUCTION.

Review Request #13499 — Created Jan. 10, 2024 and submitted — Latest diff uploaded

Information

Djblets
release-5.x

Reviewers

We have a lot of stuff that needs to behave differently in a development
environment than in production. We initially conditioned all of these on
the DEBUG setting, but a lot of users tend to turn that on when they
encounter problems, and then sometimes forget that they did so.

On the Review Board side, we've moved these things behind a new settings
key, PRODUCTION. This allows people to set DEBUG = True and get more
thorough logging, while not completely breaking their system. This
change brings that same key to Djblets.

  • Ran unit tests.
  • Smoke tested extension template loading.

Diff Revision 1

This is not the most recent revision of the diff. The latest diff is revision 2. See what's changed.

orig
1
2

Commits

First Last Summary ID Author
Switch a lot of conditional behavior over from settings.DEBUG to PRODUCTION.
We have a lot of stuff that needs to behave differently in a development environment than in production. We initially conditioned all of these on the `DEBUG` setting, but a lot of users tend to turn that on when they encounter problems, and then sometimes forget that they did so. On the Review Board side, we've moved these things behind a new settings key, `PRODUCTION`. This allows people to set `DEBUG = True` and get more thorough logging, while not completely breaking their system. This change brings that same key to Djblets. Testing Done: - Ran unit tests. - Smoke tested extension template loading.
ce33328bf362089571c4c5ddcf138222ecbfb70c David Trowbridge
djblets/settings.py
djblets/extensions/manager.py
djblets/template/loaders/conditional_cached.py
djblets/webapi/resources/root.py
djblets/webapi/tests/test_root_resource.py
tests/settings.py
Loading...