Summary

Switch a lot of conditional behavior over from settings.DEBUG to PRODUCTION.

Review Request #13499 — Created Jan. 10, 2024 and submitted Jan. 25, 2024, 9:16 a.m.

Information

Owner

david

Repository

Djblets

Branch

release-5.x

Bugs

Depends On

Reviewers

Groups

djblets

People

Description

We have a lot of stuff that needs to behave differently in a development
environment than in production. We initially conditioned all of these on
the DEBUG setting, but a lot of users tend to turn that on when they
encounter problems, and then sometimes forget that they did so.

On the Review Board side, we've moved these things behind a new settings
key, PRODUCTION. This allows people to set DEBUG = True and get more
thorough logging, while not completely breaking their system. This
change brings that same key to Djblets.

Testing Done


Ran unit tests.
Smoke tested extension template loading.

Commits

Summary	ID
Switch a lot of conditional behavior over from settings.DEBUG to PRODUCTION. We have a lot of stuff that needs to behave differently in a development environment than in production. We initially conditioned all of these on the `DEBUG` setting, but a lot of users tend to turn that on when they encounter problems, and then sometimes forget that they did so. On the Review Board side, we've moved these things behind a new settings key, `PRODUCTION`. This allows people to set `DEBUG = True` and get more thorough logging, while not completely breaking their system. This change brings that same key to Djblets. Testing Done: - Ran unit tests. - Smoke tested extension template loading.	9b4489ffd26694e8a21610332f866513eb4ee007

Summary

Switch a lot of conditional behavior over from settings.DEBUG to PRODUCTION.

We have a lot of stuff that needs to behave differently in a development environment than in production. We initially conditioned all of these on the `DEBUG` setting, but a lot of users tend to turn that on when they encounter problems, and then sometimes forget that they did so. On the Review Board side, we've moved these things behind a new settings key, `PRODUCTION`. This allows people to set `DEBUG = True` and get more thorough logging, while not completely breaking their system. This change brings that same key to Djblets. Testing Done: - Ran unit tests. - Smoke tested extension template loading.

9b4489ffd26694e8a21610332f866513eb4ee007

Issues

Description	From	Last Updated
line too long (80 > 79 characters) Column: 80 Error code: E501	reviewbot	Jan. 10, 2024, 8:38 a.m.

flake8 failed.

JSHint passed.

flake8

djblets/extensions/manager.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line too long (80 > 79 characters)

Column: 80
Error code: E501
```

Commits:

	Summary	ID
	Switch a lot of conditional behavior over from settings.DEBUG to PRODUCTION. We have a lot of stuff that needs to behave differently in a development environment than in production. We initially conditioned all of these on the `DEBUG` setting, but a lot of users tend to turn that on when they encounter problems, and then sometimes forget that they did so. On the Review Board side, we've moved these things behind a new settings key, `PRODUCTION`. This allows people to set `DEBUG = True` and get more thorough logging, while not completely breaking their system. This change brings that same key to Djblets. Testing Done: - Ran unit tests. - Smoke tested extension template loading.	ce33328bf362089571c4c5ddcf138222ecbfb70c
	Switch a lot of conditional behavior over from settings.DEBUG to PRODUCTION. We have a lot of stuff that needs to behave differently in a development environment than in production. We initially conditioned all of these on the `DEBUG` setting, but a lot of users tend to turn that on when they encounter problems, and then sometimes forget that they did so. On the Review Board side, we've moved these things behind a new settings key, `PRODUCTION`. This allows people to set `DEBUG = True` and get more thorough logging, while not completely breaking their system. This change brings that same key to Djblets. Testing Done: - Ran unit tests. - Smoke tested extension template loading.	9b4489ffd26694e8a21610332f866513eb4ee007

Diff:

Revision 2 (+42 -28)

Show changes

	djblets/settings.py
	djblets/extensions/manager.py
	djblets/template/loaders/conditional_cached.py
	djblets/webapi/resources/root.py
	djblets/webapi/tests/test_root_resource.py
	tests/settings.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-5.x (b1663a2)