Add deprecation warnings to retina image methods.

 






 

 


  Review Request #13498
  —
  Created Jan. 10, 2024 and submitted 

 




















 

  

   Information

  





 
 

  david
 









 
 

  Djblets
 









 
 

  release-5.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  djblets
 









 
 

  
 






 








 





  


 
 

  
We used to rely entirely on JavaScript to handle high-DPI ("retina")

images. These days, we use srcset for everything that comes from an

<img> tag, and media queries for anything that uses CSS

background-image.

 








  


 
 

  
    

  • Ran unit tests.
    • 

  • Did an audit of our codebases and wrote a few patches to make sure
    
  we're not using these anymore.
    • 


 







 









 





  

 


 
 

  



 

  
   


    Summary
    ID

   

  
  

   


    

     

      Add deprecation warnings to retina image methods.
      
We used to rely entirely on JavaScript to handle high-DPI ("retina")
images. These days, we use `srcset` for everything that comes from an
`<img>` tag, and media queries for anything that uses CSS
`background-image`.

Testing Done:
- Ran unit tests.
- Did an audit of our codebases and wrote a few patches to make sure
  we're not using these anymore.

     


    		
    d5a44657f0e7c62814c689c0d6ff1b1219800ebb

   



  
 




 













 









 






  

 



















 




 




 














 





 

  

   




chipx86




   

   







  

 



 

  


   

   

    
 
chipx86


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 





 

  

   




maubin




   

   







  

 



 

  


   

   

    
 
maubin


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




david




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Closed (submitted)

  
 




 
Change Summary:

 
Pushed to release-5.x (828292b)





 


 










  

 









     

    

   

  

  

   
   Loading...