Summary

Mark monkey-patched String methods as deprecated.

Review Request #13497 — Created Jan. 9, 2024 and submitted Feb. 5, 2024, 8:28 a.m.

Information

Owner

david

Repository

Djblets

Branch

release-5.x

Bugs

Depends On

Reviewers

Groups

djblets

People

Description

From a very early time, we had a few things that Djblets monkey-patched

into the standard String class for JS code. For the most part these were

either unused or duplicated by library code:

String.trim() is a standard-library method that does what our

String.strip() method did.
_.escape() and _.unescape() do what our String.htmlEncode() and

String.htmlDecode() methods did (plus are slightly more complete).
String.stripTags() was only used in one place, which was already

  doing some regex transformations, so I've just copied the

  implementation of that into where it's used.
String.truncate() isn't used anywhere.

This change marks all of them as deprecated and replaces our

implementation with the third-party ones where we can.

Testing Done

Ran js-tests.

Commits

Summary	ID
Mark monkey-patched String methods as deprecated. From a very early time, we had a few things that Djblets monkey-patched into the standard String class for JS code. For the most part these were either unused or duplicated by library code: * `String.trim()` is a standard-library method that does what our `String.strip()` method did. * `_.escape()` and `_.unescape()` do what our `String.htmlEncode()` and `String.htmlDecode()` methods did (plus are slightly more complete). * `String.stripTags()` was only used in one place, which was already doing some regex transformations, so I've just copied the implementation of that into where it's used. * `String.truncate()` isn't used anywhere. This change marks all of them as deprecated and replaces our implementation with the third-party ones where we can. Testing Done: Ran js-tests.	f153538b8b6afd98b1629490925a32f170cf1f7d

Summary

Mark monkey-patched String methods as deprecated.

From a very early time, we had a few things that Djblets monkey-patched into the standard String class for JS code. For the most part these were either unused or duplicated by library code: * `String.trim()` is a standard-library method that does what our `String.strip()` method did. * `_.escape()` and `_.unescape()` do what our `String.htmlEncode()` and `String.htmlDecode()` methods did (plus are slightly more complete). * `String.stripTags()` was only used in one place, which was already doing some regex transformations, so I've just copied the implementation of that into where it's used. * `String.truncate()` isn't used anywhere. This change marks all of them as deprecated and replaces our implementation with the third-party ones where we can. Testing Done: Ran js-tests.

f153538b8b6afd98b1629490925a32f170cf1f7d

Issues

Description	From	Last Updated
These should all say Djblets 6.	chipx86	Jan. 25, 2024, 9:14 a.m.

flake8 passed.

JSHint passed.

djblets/static/djblets/js/jquery.gravy.util.js (Diff revision 1)
The issue has been resolved. Show all issues
```
These should all say Djblets 6.
```

Commits:

	Summary	ID
	Mark monkey-patched String methods as deprecated. From a very early time, we had a few things that Djblets monkey-patched into the standard String class for JS code. For the most part these were either unused or duplicated by library code: * `String.trim()` is a standard-library method that does what our `String.strip()` method did. * `_.escape()` and `_.unescape()` do what our `String.htmlEncode()` and `String.htmlDecode()` methods did (plus are slightly more complete). * `String.stripTags()` was only used in one place, which was already doing some regex transformations, so I've just copied the implementation of that into where it's used. * `String.truncate()` isn't used anywhere. This change marks all of them as deprecated and replaces our implementation with the third-party ones where we can. Testing Done: Ran js-tests.	0605e45a4f0518555e904f84374df71ba99b38c0
	Mark monkey-patched String methods as deprecated. From a very early time, we had a few things that Djblets monkey-patched into the standard String class for JS code. For the most part these were either unused or duplicated by library code: * `String.trim()` is a standard-library method that does what our `String.strip()` method did. * `_.escape()` and `_.unescape()` do what our `String.htmlEncode()` and `String.htmlDecode()` methods did (plus are slightly more complete). * `String.stripTags()` was only used in one place, which was already doing some regex transformations, so I've just copied the implementation of that into where it's used. * `String.truncate()` isn't used anywhere. This change marks all of them as deprecated and replaces our implementation with the third-party ones where we can. Testing Done: Ran js-tests.	f153538b8b6afd98b1629490925a32f170cf1f7d

Diff:

Revision 2 (+62 -50)

Show changes

	djblets/static/djblets/js/datagrid.js
	djblets/static/djblets/js/jquery.gravy.util.js
	djblets/static/djblets/js/configForms/views/tests/tableViewTests.ts

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-5.x (c767c4e)