Remove a couple more jquery.gravy utilities.

Review Request #13493 — Created Jan. 8, 2024 and discarded

Information

Djblets
release-5.x

Reviewers

This change removes two of our patched-in jQuery methods which are no
longer useful:

  • $.setVisible() has been supplanted by $.toggle(). We switched our
    codebases over to this for Djblets 4.0/RB 6.0.
  • $.delay() exists in upstream jQuery now (and has for a long time).

Ran js-tests.

Summary ID
Remove a couple more jquery.gravy utilities.
This change removes two of our patched-in jQuery methods which are no longer useful: - `$.setVisible()` has been supplanted by `$.toggle()`. We switched our codebases over to this for Djblets 4.0/RB 6.0. - `$.delay()` exists in upstream jQuery now (and has for a long time). Testing Done: Ran js-tests.
d880b34dacf7c5195c27daa38cb51345a31b52b5
Description From Last Updated

delay() is still used in Review Board and setVisible in Power Pack. We should have at least a 2-release deprecation …

chipx86chipx86
chipx86
  1. 
      
  2. delay() is still used in Review Board and setVisible in Power Pack.

    We should have at least a 2-release deprecation period for any of these.

    1. delay is in jquery itself. We can get rid of it without any impact, even with code that calls it.

  3. 
      
david
Review request changed

Status: Discarded

Loading...