Remove old retina images JS code.

Review Request #13492 — Created Jan. 8, 2024 and discarded

Information

Djblets
release-5.x

Reviewers

We had a bunch of JS code to enable us to work with images on high-DPI
screens which is no longer useful.

The gravatar-related methods in here have long been unused, and the
Djblets.enableRetinaImages method was effectively a no-op in modern
browsers that support srcset natively. The calls to that have been
removed in Review Board, and this change removes the implementation.

  • Ran js-tests.
  • Checked that high-DPI images still appeared in places where they were
    expected.
Summary ID
Remove old retina images JS code.
We had a bunch of JS code to enable us to work with images on high-DPI screens which is no longer useful. The gravatar-related methods in here have long been unused, and the `Djblets.enableRetinaImages` method was effectively a no-op in modern browsers that support `srcset` natively. The calls to that have been removed in Review Board, and this change removes the implementation. Testing Done: - Ran js-tests. - Checked that high-DPI images still appeared in places where they were expected.
41fcd0847831c1daa28127f3ed9cf95b5c8b7a36
Description From Last Updated

These are still used in Power Pack. We should have at least a 2-release deprecation period for anything being removed.

chipx86chipx86
chipx86
  1. 
      
  2. Show all issues

    These are still used in Power Pack.

    We should have at least a 2-release deprecation period for anything being removed.

  3. 
      
david
Review request changed

Status: Discarded

Loading...