Summary

Remove old retina images JS code.

Review Request #13492 — Created Jan. 8, 2024 and discarded Jan. 10, 2024, 8:36 a.m.

Information

Owner

david

Repository

Djblets

Branch

release-5.x

Bugs

Depends On

Reviewers

Groups

djblets

People

Description

We had a bunch of JS code to enable us to work with images on high-DPI
screens which is no longer useful.

The gravatar-related methods in here have long been unused, and the
Djblets.enableRetinaImages method was effectively a no-op in modern
browsers that support srcset natively. The calls to that have been
removed in Review Board, and this change removes the implementation.

Testing Done


Ran js-tests.
Checked that high-DPI images still appeared in places where they were

  expected.

Commits

Summary	ID
Remove old retina images JS code. We had a bunch of JS code to enable us to work with images on high-DPI screens which is no longer useful. The gravatar-related methods in here have long been unused, and the `Djblets.enableRetinaImages` method was effectively a no-op in modern browsers that support `srcset` natively. The calls to that have been removed in Review Board, and this change removes the implementation. Testing Done: - Ran js-tests. - Checked that high-DPI images still appeared in places where they were expected.	41fcd0847831c1daa28127f3ed9cf95b5c8b7a36

Summary

Remove old retina images JS code.

We had a bunch of JS code to enable us to work with images on high-DPI screens which is no longer useful. The gravatar-related methods in here have long been unused, and the `Djblets.enableRetinaImages` method was effectively a no-op in modern browsers that support `srcset` natively. The calls to that have been removed in Review Board, and this change removes the implementation. Testing Done: - Ran js-tests. - Checked that high-DPI images still appeared in places where they were expected.

41fcd0847831c1daa28127f3ed9cf95b5c8b7a36

Issues

Description	From	Last Updated
These are still used in Power Pack. We should have at least a 2-release deprecation period for anything being removed.	chipx86	Jan. 8, 2024, 2:37 p.m.

flake8 passed.

JSHint passed.

Fix it!

An issue was opened. Show all issues

These are still used in Power Pack.

We should have at least a 2-release deprecation period for anything being removed.

Status:: Discarded