Summary

Switch out django timezone.utc for datetime.timezone.utc.

Review Request #13485 — Created Jan. 4, 2024 and submitted Jan. 19, 2024, 12:17 p.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Now that the python standard library has a UTC object, django has
deprecated theirs. This change swaps our our usage.

Testing Done

Ran unit tests.

Commits

Summary	ID
Switch out django timezone.utc for datetime.timezone.utc. Now that the python standard library has a UTC object, django has deprecated theirs. This change swaps our our usage. Testing Done: Ran unit tests.	f09ad6d1e009858343618444a62d1a238f31abe3

Issues

Description	From	Last Updated
line too long (82 > 79 characters) Column: 80 Error code: E501	reviewbot	Jan. 4, 2024, 4:29 p.m.
line too long (82 > 79 characters) Column: 80 Error code: E501	reviewbot	Jan. 4, 2024, 4:29 p.m.
line too long (81 > 79 characters) Column: 80 Error code: E501	reviewbot	Jan. 4, 2024, 4:30 p.m.
line too long (80 > 79 characters) Column: 80 Error code: E501	reviewbot	Jan. 4, 2024, 4:30 p.m.
line too long (80 > 79 characters) Column: 80 Error code: E501	reviewbot	Jan. 4, 2024, 4:30 p.m.
line too long (84 > 79 characters) Column: 80 Error code: E501	reviewbot	Jan. 4, 2024, 4:30 p.m.
line too long (80 > 79 characters) Column: 80 Error code: E501	reviewbot	Jan. 4, 2024, 4:30 p.m.
line too long (84 > 79 characters) Column: 80 Error code: E501	reviewbot	Jan. 4, 2024, 4:31 p.m.
line too long (81 > 79 characters) Column: 80 Error code: E501	reviewbot	Jan. 4, 2024, 4:31 p.m.
line too long (80 > 79 characters) Column: 80 Error code: E501	reviewbot	Jan. 4, 2024, 4:31 p.m.
line too long (82 > 79 characters) Column: 80 Error code: E501	reviewbot	Jan. 4, 2024, 4:31 p.m.
line too long (81 > 79 characters) Column: 80 Error code: E501	reviewbot	Jan. 4, 2024, 4:32 p.m.
line too long (81 > 79 characters) Column: 80 Error code: E501	reviewbot	Jan. 4, 2024, 4:32 p.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/certs/cert.py (Diff revision 1)
The issue has been resolved. Show all issues
```
line too long (82 > 79 characters)

Column: 80
Error code: E501
```
reviewboard/reviews/detail.py (Diff revision 1)
The issue has been resolved. Show all issues
```
line too long (82 > 79 characters)

Column: 80
Error code: E501
```
reviewboard/reviews/detail.py (Diff revision 1)
The issue has been resolved. Show all issues
```
line too long (81 > 79 characters)

Column: 80
Error code: E501
```
reviewboard/reviews/tests/test_entries.py (Diff revision 1)
The issue has been resolved. Show all issues
```
line too long (80 > 79 characters)

Column: 80
Error code: E501
```
reviewboard/reviews/tests/test_entries.py (Diff revision 1)
The issue has been resolved. Show all issues
```
line too long (80 > 79 characters)

Column: 80
Error code: E501
```
reviewboard/reviews/tests/test_entries.py (Diff revision 1)
The issue has been resolved. Show all issues
```
line too long (84 > 79 characters)

Column: 80
Error code: E501
```
reviewboard/reviews/tests/test_entries.py (Diff revision 1)
The issue has been resolved. Show all issues
```
line too long (80 > 79 characters)

Column: 80
Error code: E501
```
reviewboard/reviews/tests/test_entries.py (Diff revision 1)
The issue has been resolved. Show all issues
```
line too long (84 > 79 characters)

Column: 80
Error code: E501
```
reviewboard/reviews/tests/test_entries.py (Diff revision 1)
The issue has been resolved. Show all issues
```
line too long (81 > 79 characters)

Column: 80
Error code: E501
```
reviewboard/reviews/tests/test_entries.py (Diff revision 1)
The issue has been resolved. Show all issues
```
line too long (80 > 79 characters)

Column: 80
Error code: E501
```
reviewboard/reviews/tests/test_entries.py (Diff revision 1)
The issue has been resolved. Show all issues
```
line too long (82 > 79 characters)

Column: 80
Error code: E501
```
reviewboard/reviews/tests/test_review.py (Diff revision 1)
The issue has been resolved. Show all issues
```
line too long (81 > 79 characters)

Column: 80
Error code: E501
```
reviewboard/webapi/tests/test_review.py (Diff revision 1)
The issue has been resolved. Show all issues
```
line too long (81 > 79 characters)

Column: 80
Error code: E501
```

Commits:

	Summary	ID
	Switch out django timezone.utc for datetime.timezone.utc. Now that the python standard library has a UTC object, django has deprecated theirs. This change swaps our our usage. Testing Done: Ran unit tests.	b1c2ada9ad72a7755375e7d3fb41d98f1ded9351
	Switch out django timezone.utc for datetime.timezone.utc. Now that the python standard library has a UTC object, django has deprecated theirs. This change swaps our our usage. Testing Done: Ran unit tests.	f09ad6d1e009858343618444a62d1a238f31abe3

Diff:

Revision 2 (+228 -208)

Show changes

	reviewboard/accounts/tests/test_update_last_login_middleware.py
	reviewboard/certs/cert.py
	reviewboard/certs/tests/test_certificate.py
	reviewboard/certs/tests/test_certificate_verification_error.py
	reviewboard/reviews/detail.py
	reviewboard/reviews/tests/test_entries.py
	reviewboard/reviews/tests/test_review.py
	reviewboard/reviews/tests/test_review_request_updates_view.py
	7 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-7.x (8fd3e68)

reviewboard/certs/cert.py (Diff revision 1)