Summary

Add type hints to SCMToolRegistry.

Review Request #13474 — Created Jan. 1, 2024 and submitted Jan. 3, 2024, 2 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-6.x

Bugs

Depends On

Blocks

13475

Reviewers

Groups

reviewboard

People

Description

This fleshes out the type hints in SCMToolRegistry, ensuring that the
registration implementation code and consumers of the registry are all
aware of what types are being put in and returned.

Some code has been modernized in the process. Namely, converting
super() calls to their short form, and leveraging yield from and
f-strings.

This is in preparation for some work that will lead to new SCM support.

Testing Done

Unit tests pass.

Type checkers pass.

Verified the typing when fetching resulting tools.

Commits

Summary	ID
Add type hints to SCMToolRegistry. This fleshes out the type hints in `SCMToolRegistry`, ensuring that the registration implementation code and consumers of the registry are all aware of what types are being put in and returned. Some code has been modernized in the process. Namely, converting `super()` calls to their short form, and leveraging `yield from` and f-strings. This is in preparation for some work that will lead to new SCM support.	ae38039ed9ec286fd4f7df0f26306292ad7bbb73

Summary

Add type hints to SCMToolRegistry.

This fleshes out the type hints in `SCMToolRegistry`, ensuring that the registration implementation code and consumers of the registry are all aware of what types are being put in and returned. Some code has been modernized in the process. Namely, converting `super()` calls to their short form, and leveraging `yield from` and f-strings. This is in preparation for some work that will lead to new SCM support.

ae38039ed9ec286fd4f7df0f26306292ad7bbb73

Issues

Description	From	Last Updated
undefined name 'ClassVar' Column: 17 Error code: F821	reviewbot	Jan. 1, 2024, 3:23 p.m.
Mind fixing the grammar here while you're at it?	david	Jan. 3, 2024, 1:58 p.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/scmtools/core.py (Diff revision 1)
The issue has been resolved. Show all issues
```
undefined name 'ClassVar'

Column: 17
Error code: F821
```

Change Summary:

Added a missing import.

Commits:

	Summary	ID
	Add type hints to SCMToolRegistry. This fleshes out the type hints in `SCMToolRegistry`, ensuring that the registration implementation code and consumers of the registry are all aware of what types are being put in and returned. Some code has been modernized in the process. Namely, converting `super()` calls to their short form, and leveraging `yield from` and f-strings. This is in preparation for some work that will lead to new SCM support.	be394896258da3fb81aa3b5ce690fcc955a8e252
	Add type hints to SCMToolRegistry. This fleshes out the type hints in `SCMToolRegistry`, ensuring that the registration implementation code and consumers of the registry are all aware of what types are being put in and returned. Some code has been modernized in the process. Namely, converting `super()` calls to their short form, and leveraging `yield from` and f-strings. This is in preparation for some work that will lead to new SCM support.	ae38039ed9ec286fd4f7df0f26306292ad7bbb73

Diff:

Revision 2 (+140 -52)

Show changes

	reviewboard/scmtools/core.py
	reviewboard/scmtools/registry.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

reviewboard/scmtools/registry.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Mind fixing the grammar here while you're at it?
```

Status: Closed (submitted)

Change Summary:

Pushed to release-6.x (15d4a52)