flake8
failed.
JSHint
passed.
flake8
-
scripts/templates/bootstrap.py (Diff revision 1) -
scripts/templates/bootstrap.py (Diff revision 1) undefined name 'get_installer_data' Column: 35 Error code: F821
Add scripts for building a bootstrap installer.
Review Request #13468 — Created Dec. 27, 2023 and submitted
In order to simplify installation, we'll be distributing the Review
Board installer as a single file, able to be run usingcurl | python.To do this, we'll be distributing the primary installer as a
booststrapping Python script that contains an embedded copy of the
installer's wheel. The bootstrapping installer sets up a temporary
virtualenv (usingpython -m venv), installs the package within that,
and then runs it. This ensures we can run in a stable environment.
scripts/pack.shis responsible for building the bootstrap installer
and the wheel, and then embedding the wheel within the bootstrap
installer.
Successfully built the installer and ran it in all supported Linux
distributions.
| Summary | ID |
|---|---|
| c358317b5872c9d6fb51812c1bd1f7d5654c466f |
| Description | From | Last Updated |
|---|---|---|
|
undefined name 'rbinstall_whl_filename' Column: 45 Error code: F821 |
 reviewbot
|
|
|
undefined name 'get_installer_data' Column: 35 Error code: F821 |
reviewbot
|
|
|
undefined name 'rbinstall_whl_filename' Column: 45 Error code: F821 |
reviewbot
|
|
|
undefined name 'get_installer_data' Column: 35 Error code: F821 |
reviewbot
|
Change Summary:
- Improved output when preparing the installer.
- Added graceful handling of non-0 exit codes.
- Passed along the system Python to the installer.
Commits: |
|
|||||||
|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+202) |
Checks run (1 failed, 1 succeeded)
flake8
failed.
JSHint
passed.
flake8
-
scripts/templates/bootstrap.py (Diff revision 2) undefined name 'rbinstall_whl_filename' Column: 45 Error code: F821
-
scripts/templates/bootstrap.py (Diff revision 2) undefined name 'get_installer_data' Column: 35 Error code: F821
