Summary

Add scripts for building a bootstrap installer.

Review Request #13468 — Created Dec. 27, 2023 and submitted Jan. 12, 2024, 4:18 p.m.

Information

Owner

chipx86

Repository

rbinstall

Branch

master

Bugs

Depends On

~~13467~~

Blocks

13469

Reviewers

Groups

reviewboard

People

Description

In order to simplify installation, we'll be distributing the Review

Board installer as a single file, able to be run using curl | python.
To do this, we'll be distributing the primary installer as a

booststrapping Python script that contains an embedded copy of the

installer's wheel. The bootstrapping installer sets up a temporary

virtualenv (using python -m venv), installs the package within that,

and then runs it. This ensures we can run in a stable environment.
scripts/pack.sh is responsible for building the bootstrap installer

and the wheel, and then embedding the wheel within the bootstrap

installer.

Testing Done

Successfully built the installer and ran it in all supported Linux
distributions.

Commits

Summary	ID
Add scripts for building a bootstrap installer. In order to simplify installation, we'll be distributing the Review Board installer as a single file, able to be run using `curl \| python`. To do this, we'll be distributing the primary installer as a booststrapping Python script that contains an embedded copy of the installer's wheel. The bootstrapping installer sets up a temporary virtualenv (using `python -m venv`), installs the package within that, and then runs it. This ensures we can run in a stable environment. `scripts/pack.sh` is responsible for building the bootstrap installer and the wheel, and then embedding the wheel within the bootstrap installer.	c358317b5872c9d6fb51812c1bd1f7d5654c466f

Summary

Add scripts for building a bootstrap installer.

In order to simplify installation, we'll be distributing the Review Board installer as a single file, able to be run using `curl | python`. To do this, we'll be distributing the primary installer as a booststrapping Python script that contains an embedded copy of the installer's wheel. The bootstrapping installer sets up a temporary virtualenv (using `python -m venv`), installs the package within that, and then runs it. This ensures we can run in a stable environment. `scripts/pack.sh` is responsible for building the bootstrap installer and the wheel, and then embedding the wheel within the bootstrap installer.

c358317b5872c9d6fb51812c1bd1f7d5654c466f

Issues

Description	From	Last Updated
undefined name 'rbinstall_whl_filename' Column: 45 Error code: F821	reviewbot	Dec. 27, 2023, 3:51 a.m.
undefined name 'get_installer_data' Column: 35 Error code: F821	reviewbot	Dec. 27, 2023, 3:51 a.m.
undefined name 'rbinstall_whl_filename' Column: 45 Error code: F821	reviewbot	Jan. 3, 2024, 1:44 a.m.
undefined name 'get_installer_data' Column: 35 Error code: F821	reviewbot	Jan. 3, 2024, 1:44 a.m.

flake8 failed.

JSHint passed.

flake8

scripts/templates/bootstrap.py (Diff revision 1)
The issue has been dropped. Show all issues
```
undefined name 'rbinstall_whl_filename'

Column: 45
Error code: F821
```
scripts/templates/bootstrap.py (Diff revision 1)
The issue has been dropped. Show all issues
```
undefined name 'get_installer_data'

Column: 35
Error code: F821
```

Change Summary:


Improved output when preparing the installer.
Added graceful handling of non-0 exit codes.
Passed along the system Python to the installer.

Commits:

	Summary	ID
	Add scripts for building a bootstrap installer. In order to simplify installation, we'll be distributing the Review Board installer as a single file, able to be run using `curl \| python`. To do this, we'll be distributing the primary installer as a booststrapping Python script that contains an embedded copy of the installer's wheel. The bootstrapping installer sets up a temporary virtualenv (using `python -m venv`), installs the package within that, and then runs it. This ensures we can run in a stable environment. `scripts/pack.sh` is responsible for building the bootstrap installer and the wheel, and then embedding the wheel within the bootstrap installer.	65e20a2697367fe31ab31c5315721656936458d9
	Add scripts for building a bootstrap installer. In order to simplify installation, we'll be distributing the Review Board installer as a single file, able to be run using `curl \| python`. To do this, we'll be distributing the primary installer as a booststrapping Python script that contains an embedded copy of the installer's wheel. The bootstrapping installer sets up a temporary virtualenv (using `python -m venv`), installs the package within that, and then runs it. This ensures we can run in a stable environment. `scripts/pack.sh` is responsible for building the bootstrap installer and the wheel, and then embedding the wheel within the bootstrap installer.	c358317b5872c9d6fb51812c1bd1f7d5654c466f

Diff:

Revision 2 (+202)

Show changes

	scripts/pack.sh
	scripts/templates/bootstrap.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

scripts/templates/bootstrap.py (Diff revision 2)
The issue has been dropped. Show all issues
```
undefined name 'rbinstall_whl_filename'

Column: 45
Error code: F821
```
scripts/templates/bootstrap.py (Diff revision 2)
The issue has been dropped. Show all issues
```
undefined name 'get_installer_data'

Column: 35
Error code: F821
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (6820d1c)