Summary

Add distro definitions and install steps for package installation.

Review Request #13465 — Created Dec. 27, 2023 and submitted Jan. 12, 2024, 3:57 p.m.

Information

Owner

chipx86

Repository

rbinstall

Branch

master

Bugs

Depends On

~~13464~~

Blocks

13466

Reviewers

Groups

reviewboard

People

Description

The new rbinstall.distro_info module contains definitions for all the

Linux distributions that are supported by the installer. This defines

the packages and other commands needed to install Review Board and its

dependencies across various versions of Amazon Linux, Arch Linux,

CentOS, Debian, Fedora, openSUSE, RHEL, Rocky Linux, RHEL, and Ubuntu.
The definitions are parsed by functions in rbinstall.install_steps,

which turns them into commands to be run for handling package

installation.
Unit tests exist for all supported distros, in order to help catch any

changes to package installation. These have also all been tested against

Docker-based installs of each distro.

Testing Done

Unit tests pass.

Tested these definitions on all supported Linux distributions.

Commits

Summary	ID
Add distro definitions and install steps for package installation. The new `rbinstall.distro_info` module contains definitions for all the Linux distributinos that are supported by the installer. This defines the packages and other commands needed to install Review Board and its dependencies across various versions of Amazon Linux, Arch Linux, CentOS, Debian, Fedora, openSUSE, RHEL, Rocky Linux, RHEL, and Ubuntu. The definitions are parsed by functions in `rbinstall.install_steps`, which turns them into commands to be run for handling package installation. Unit tests exist for all supported distros, in order to help catch any changes to package installation. These have also all been tested against Docker-based installs of each distro.	0de0c043ebb7ba8874d478a0445b037c9f7870d0

Summary

Add distro definitions and install steps for package installation.

The new `rbinstall.distro_info` module contains definitions for all the Linux distributinos that are supported by the installer. This defines the packages and other commands needed to install Review Board and its dependencies across various versions of Amazon Linux, Arch Linux, CentOS, Debian, Fedora, openSUSE, RHEL, Rocky Linux, RHEL, and Ubuntu. The definitions are parsed by functions in `rbinstall.install_steps`, which turns them into commands to be run for handling package installation. Unit tests exist for all supported distros, in order to help catch any changes to package installation. These have also all been tested against Docker-based installs of each distro.

0de0c043ebb7ba8874d478a0445b037c9f7870d0

Issues

Description	From	Last Updated
Typo in description "distributinos".	maubin	Jan. 6, 2024, 10:02 p.m.
'typing.TYPE_CHECKING' imported but unused Column: 1 Error code: F401	reviewbot	Dec. 27, 2023, 3:07 a.m.
'typing.Callable' imported but unused Column: 1 Error code: F401	reviewbot	Dec. 27, 2023, 3:07 a.m.
'os' imported but unused Column: 1 Error code: F401	reviewbot	Dec. 27, 2023, 3:07 a.m.
'platform' imported but unused Column: 1 Error code: F401	reviewbot	Dec. 27, 2023, 3:07 a.m.
're' imported but unused Column: 1 Error code: F401	reviewbot	Dec. 27, 2023, 3:07 a.m.
'subprocess' imported but unused Column: 1 Error code: F401	reviewbot	Dec. 27, 2023, 3:07 a.m.
'sys' imported but unused Column: 1 Error code: F401	reviewbot	Dec. 27, 2023, 3:07 a.m.
'tempfile' imported but unused Column: 1 Error code: F401	reviewbot	Dec. 27, 2023, 3:07 a.m.
'typing.Any' imported but unused Column: 1 Error code: F401	reviewbot	Dec. 27, 2023, 3:07 a.m.
'typing.Dict' imported but unused Column: 1 Error code: F401	reviewbot	Dec. 27, 2023, 3:07 a.m.
'gettext.ngettext' imported but unused Column: 1 Error code: F401	reviewbot	Jan. 3, 2024, 1:41 a.m.
Typo "withi"	maubin	Jan. 6, 2024, 10:03 p.m.

flake8 failed.

JSHint passed.

flake8

rbinstall/distro_info.py (Diff revision 1)
The issue has been resolved. Show all issues
```
'typing.TYPE_CHECKING' imported but unused

Column: 1
Error code: F401
```
rbinstall/distro_info.py (Diff revision 1)
The issue has been resolved. Show all issues
```
'typing.Callable' imported but unused

Column: 1
Error code: F401
```
rbinstall/tests/test_install_steps.py (Diff revision 1)
The issue has been resolved. Show all issues
```
'os' imported but unused

Column: 1
Error code: F401
```
rbinstall/tests/test_install_steps.py (Diff revision 1)
The issue has been resolved. Show all issues
```
'platform' imported but unused

Column: 1
Error code: F401
```
rbinstall/tests/test_install_steps.py (Diff revision 1)
The issue has been resolved. Show all issues
```
're' imported but unused

Column: 1
Error code: F401
```
rbinstall/tests/test_install_steps.py (Diff revision 1)
The issue has been resolved. Show all issues
```
'subprocess' imported but unused

Column: 1
Error code: F401
```
rbinstall/tests/test_install_steps.py (Diff revision 1)
The issue has been resolved. Show all issues
```
'sys' imported but unused

Column: 1
Error code: F401
```
rbinstall/tests/test_install_steps.py (Diff revision 1)
The issue has been resolved. Show all issues
```
'tempfile' imported but unused

Column: 1
Error code: F401
```
rbinstall/tests/test_install_steps.py (Diff revision 1)
The issue has been resolved. Show all issues
```
'typing.Any' imported but unused

Column: 1
Error code: F401
```
rbinstall/tests/test_install_steps.py (Diff revision 1)
The issue has been resolved. Show all issues
```
'typing.Dict' imported but unused

Column: 1
Error code: F401
```

Change Summary:

Removed unused imports.

Commits:

	Summary	ID
	Add distro definitions and install steps for package installation. The new `rbinstall.distro_info` module contains definitions for all the Linux distributinos that are supported by the installer. This defines the packages and other commands needed to install Review Board and its dependencies across various versions of Amazon Linux, Arch Linux, CentOS, Debian, Fedora, openSUSE, RHEL, Rocky Linux, RHEL, and Ubuntu. The definitions are parsed by functions in `rbinstall.install_steps`, which turns them into commands to be run for handling package installation. Unit tests exist for all supported distros, in order to help catch any changes to package installation. These have also all been tested against Docker-based installs of each distro.	08e7449b23085a966c631aab2f77dd1ade9b72f9
	Add distro definitions and install steps for package installation. The new `rbinstall.distro_info` module contains definitions for all the Linux distributinos that are supported by the installer. This defines the packages and other commands needed to install Review Board and its dependencies across various versions of Amazon Linux, Arch Linux, CentOS, Debian, Fedora, openSUSE, RHEL, Rocky Linux, RHEL, and Ubuntu. The definitions are parsed by functions in `rbinstall.install_steps`, which turns them into commands to be run for handling package installation. Unit tests exist for all supported distros, in order to help catch any changes to package installation. These have also all been tested against Docker-based installs of each distro.	378aa19567f2177b5c38c2b6b4a97a2f9d4819da

Diff:

Revision 2 (+7026)

Show changes

	rbinstall/distro_info.py
	rbinstall/install_steps.py
	rbinstall/versioning.py
	rbinstall/tests/test_install_steps.py
	rbinstall/tests/test_versioning.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Change Summary:


Updated for new install state, particularly for version information.
Improved the descriptions for each install step.

Commits:

	Summary	ID
	Add distro definitions and install steps for package installation. The new `rbinstall.distro_info` module contains definitions for all the Linux distributinos that are supported by the installer. This defines the packages and other commands needed to install Review Board and its dependencies across various versions of Amazon Linux, Arch Linux, CentOS, Debian, Fedora, openSUSE, RHEL, Rocky Linux, RHEL, and Ubuntu. The definitions are parsed by functions in `rbinstall.install_steps`, which turns them into commands to be run for handling package installation. Unit tests exist for all supported distros, in order to help catch any changes to package installation. These have also all been tested against Docker-based installs of each distro.	378aa19567f2177b5c38c2b6b4a97a2f9d4819da
	Add distro definitions and install steps for package installation. The new `rbinstall.distro_info` module contains definitions for all the Linux distributinos that are supported by the installer. This defines the packages and other commands needed to install Review Board and its dependencies across various versions of Amazon Linux, Arch Linux, CentOS, Debian, Fedora, openSUSE, RHEL, Rocky Linux, RHEL, and Ubuntu. The definitions are parsed by functions in `rbinstall.install_steps`, which turns them into commands to be run for handling package installation. Unit tests exist for all supported distros, in order to help catch any changes to package installation. These have also all been tested against Docker-based installs of each distro.	695c6077938c0726a5cbe42dfc5abb730325c3fe

Diff:

Revision 3 (+7084)

Show changes

	rbinstall/distro_info.py
	rbinstall/install_steps.py
	rbinstall/versioning.py
	rbinstall/tests/test_install_steps.py
	rbinstall/tests/test_versioning.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

rbinstall/install_steps.py (Diff revision 3)
The issue has been resolved. Show all issues
```
'gettext.ngettext' imported but unused

Column: 1
Error code: F401
```

Change Summary:

Removed an unused import.

Commits:

	Summary	ID
	Add distro definitions and install steps for package installation. The new `rbinstall.distro_info` module contains definitions for all the Linux distributinos that are supported by the installer. This defines the packages and other commands needed to install Review Board and its dependencies across various versions of Amazon Linux, Arch Linux, CentOS, Debian, Fedora, openSUSE, RHEL, Rocky Linux, RHEL, and Ubuntu. The definitions are parsed by functions in `rbinstall.install_steps`, which turns them into commands to be run for handling package installation. Unit tests exist for all supported distros, in order to help catch any changes to package installation. These have also all been tested against Docker-based installs of each distro.	695c6077938c0726a5cbe42dfc5abb730325c3fe
	Add distro definitions and install steps for package installation. The new `rbinstall.distro_info` module contains definitions for all the Linux distributinos that are supported by the installer. This defines the packages and other commands needed to install Review Board and its dependencies across various versions of Amazon Linux, Arch Linux, CentOS, Debian, Fedora, openSUSE, RHEL, Rocky Linux, RHEL, and Ubuntu. The definitions are parsed by functions in `rbinstall.install_steps`, which turns them into commands to be run for handling package installation. Unit tests exist for all supported distros, in order to help catch any changes to package installation. These have also all been tested against Docker-based installs of each distro.	57f55b8d997537fe24e1df735cdd72e0a3d5420d

Diff:

Revision 4 (+7084)

Show changes

	rbinstall/distro_info.py
	rbinstall/install_steps.py
	rbinstall/versioning.py
	rbinstall/tests/test_install_steps.py
	rbinstall/tests/test_versioning.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Change Summary:

Updated distro definitions to match the new install steps.

Commits:

	Summary	ID
	Add distro definitions and install steps for package installation. The new `rbinstall.distro_info` module contains definitions for all the Linux distributinos that are supported by the installer. This defines the packages and other commands needed to install Review Board and its dependencies across various versions of Amazon Linux, Arch Linux, CentOS, Debian, Fedora, openSUSE, RHEL, Rocky Linux, RHEL, and Ubuntu. The definitions are parsed by functions in `rbinstall.install_steps`, which turns them into commands to be run for handling package installation. Unit tests exist for all supported distros, in order to help catch any changes to package installation. These have also all been tested against Docker-based installs of each distro.	57f55b8d997537fe24e1df735cdd72e0a3d5420d
	Add distro definitions and install steps for package installation. The new `rbinstall.distro_info` module contains definitions for all the Linux distributinos that are supported by the installer. This defines the packages and other commands needed to install Review Board and its dependencies across various versions of Amazon Linux, Arch Linux, CentOS, Debian, Fedora, openSUSE, RHEL, Rocky Linux, RHEL, and Ubuntu. The definitions are parsed by functions in `rbinstall.install_steps`, which turns them into commands to be run for handling package installation. Unit tests exist for all supported distros, in order to help catch any changes to package installation. These have also all been tested against Docker-based installs of each distro.	3862d322d7e35e601d8ff00a80c598192d0b0008

Diff:

Revision 5 (+7084)

Show changes

	rbinstall/distro_info.py
	rbinstall/install_steps.py
	rbinstall/versioning.py
	rbinstall/tests/test_install_steps.py
	rbinstall/tests/test_versioning.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

The issue has been resolved. Show all issues
```
Typo in description "distributinos".
```
rbinstall/install_steps.py (Diff revision 5)
The issue has been resolved. Show all issues
```
Typo "withi"
```

Change Summary:

Fixed typos.

Description:

		The new `rbinstall.distro_info` module contains definitions for all the
~		Linux distributinos that are supported by the installer. This defines
	~	Linux distributions that are supported by the installer. This defines
		the packages and other commands needed to install Review Board and its
		dependencies across various versions of Amazon Linux, Arch Linux,
		CentOS, Debian, Fedora, openSUSE, RHEL, Rocky Linux, RHEL, and Ubuntu.

		The definitions are parsed by functions in `rbinstall.install_steps`,
		which turns them into commands to be run for handling package
		installation.

		Unit tests exist for all supported distros, in order to help catch any
		changes to package installation. These have also all been tested against
		Docker-based installs of each distro.

Commits:

	Summary	ID
	Add distro definitions and install steps for package installation. The new `rbinstall.distro_info` module contains definitions for all the Linux distributinos that are supported by the installer. This defines the packages and other commands needed to install Review Board and its dependencies across various versions of Amazon Linux, Arch Linux, CentOS, Debian, Fedora, openSUSE, RHEL, Rocky Linux, RHEL, and Ubuntu. The definitions are parsed by functions in `rbinstall.install_steps`, which turns them into commands to be run for handling package installation. Unit tests exist for all supported distros, in order to help catch any changes to package installation. These have also all been tested against Docker-based installs of each distro.	3862d322d7e35e601d8ff00a80c598192d0b0008
	Add distro definitions and install steps for package installation. The new `rbinstall.distro_info` module contains definitions for all the Linux distributinos that are supported by the installer. This defines the packages and other commands needed to install Review Board and its dependencies across various versions of Amazon Linux, Arch Linux, CentOS, Debian, Fedora, openSUSE, RHEL, Rocky Linux, RHEL, and Ubuntu. The definitions are parsed by functions in `rbinstall.install_steps`, which turns them into commands to be run for handling package installation. Unit tests exist for all supported distros, in order to help catch any changes to package installation. These have also all been tested against Docker-based installs of each distro.	0de0c043ebb7ba8874d478a0445b037c9f7870d0

Diff:

Revision 6 (+7084)

Show changes

	rbinstall/distro_info.py
	rbinstall/install_steps.py
	rbinstall/versioning.py
	rbinstall/tests/test_install_steps.py
	rbinstall/tests/test_versioning.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to master (88aefaa)

rbinstall/distro_info.py (Diff revision 1)

rbinstall/distro_info.py (Diff revision 1)

rbinstall/install_steps.py (Diff revision 3)

rbinstall/install_steps.py (Diff revision 5)