Summary

Add support for installing packages using a variety of methods.

Review Request #13464 — Created Dec. 27, 2023 and submitted Jan. 12, 2024, 3:57 p.m.

Information

Owner

chipx86

Repository

rbinstall

Branch

master

Bugs

Depends On

~~13463~~

Blocks

13465

Reviewers

Groups

reviewboard

People

Description

This introduces an abstraction layer for installing packages using a

variety of methods. This includes:

apt-get build-dep
apt-get install
brew install
curl <url> | pythonX.Y
pacman
pip install ReviewBoard[...]
pip install
yum install
zypper install
Arbitrary shell commands

This is all done by running run_install_method() and passing in the

appropriate arguments. It will be used for package installation in an

upcoming change.

Testing Done

Unit tests pass.

Tested each of these with the rest of the upcoming installer changes.

Commits

Summary	ID
Add support for installing packages using a variety of methods. This introduces an abstraction layer for installing packages using a variety of methods. This includes: * `apt-get build-dep` * `apt-get install` * `brew install` * `curl <url> \| pythonX.Y` * `pacman` * `pip install ReviewBoard[...]` * `pip install` * `yum install` * `zypper install` * Arbitrary shell commands This is all done by running `run_install_method()` and passing in the appropriate arguments. It will be used for package installation in an upcoming change.	43bdc609d3ea98d546a9ba0c297ada8d7095dbd6

Summary

Add support for installing packages using a variety of methods.

This introduces an abstraction layer for installing packages using a variety of methods. This includes: * `apt-get build-dep` * `apt-get install` * `brew install` * `curl <url> | pythonX.Y` * `pacman` * `pip install ReviewBoard[...]` * `pip install` * `yum install` * `zypper install` * Arbitrary shell commands This is all done by running `run_install_method()` and passing in the appropriate arguments. It will be used for package installation in an upcoming change.

43bdc609d3ea98d546a9ba0c297ada8d7095dbd6

Issues

Description	From	Last Updated
'subprocess.CalledProcessError' imported but unused Column: 1 Error code: F401	reviewbot	Dec. 27, 2023, 12:01 a.m.
'rbinstall.errors.InstallerError' imported but unused Column: 1 Error code: F401	reviewbot	Dec. 27, 2023, 12:01 a.m.
'typing.Optional' imported but unused Column: 1 Error code: F401	reviewbot	Jan. 3, 2024, 1:39 a.m.

flake8 failed.

JSHint passed.

flake8

rbinstall/tests/test_install_methods.py (Diff revision 1)
The issue has been resolved. Show all issues
```
'subprocess.CalledProcessError' imported but unused

Column: 1
Error code: F401
```
rbinstall/tests/test_install_methods.py (Diff revision 1)
The issue has been resolved. Show all issues
```
'rbinstall.errors.InstallerError' imported but unused

Column: 1
Error code: F401
```

Change Summary:

Removed unused imports.

Commits:

	Summary	ID
	Add support for installing packages using a variety of methods. This introduces an abstraction layer for installing packages using a variety of methods. This includes: * `apt-get build-dep` * `apt-get install` * `brew install` * `curl <url> \| pythonX.Y` * `pacman` * `pip install ReviewBoard[...]` * `pip install` * `yum install` * `zypper install` * Arbitrary shell commands This is all done by running `run_install_method()` and passing in the appropriate arguments. It will be used for package installation in an upcoming change.	d957a0effb1e0f2a7437eecfbca27dc4577506fa
	Add support for installing packages using a variety of methods. This introduces an abstraction layer for installing packages using a variety of methods. This includes: * `apt-get build-dep` * `apt-get install` * `brew install` * `curl <url> \| pythonX.Y` * `pacman` * `pip install ReviewBoard[...]` * `pip install` * `yum install` * `zypper install` * Arbitrary shell commands This is all done by running `run_install_method()` and passing in the appropriate arguments. It will be used for package installation in an upcoming change.	6460ff24a4fdd29c1e2992ba00dfb306e6adc0c1

Diff:

Revision 2 (+1832 -2)

Show changes

	rbinstall/errors.py
	rbinstall/install_methods.py
	rbinstall/tests/test_install_methods.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Change Summary:


Added dry-run and arbitrary run() argument support for install methods.
Remote pyscript installs now output a simulated curl <URL> | python command.

Commits:

	Summary	ID
	Add support for installing packages using a variety of methods. This introduces an abstraction layer for installing packages using a variety of methods. This includes: * `apt-get build-dep` * `apt-get install` * `brew install` * `curl <url> \| pythonX.Y` * `pacman` * `pip install ReviewBoard[...]` * `pip install` * `yum install` * `zypper install` * Arbitrary shell commands This is all done by running `run_install_method()` and passing in the appropriate arguments. It will be used for package installation in an upcoming change.	6460ff24a4fdd29c1e2992ba00dfb306e6adc0c1
	Add support for installing packages using a variety of methods. This introduces an abstraction layer for installing packages using a variety of methods. This includes: * `apt-get build-dep` * `apt-get install` * `brew install` * `curl <url> \| pythonX.Y` * `pacman` * `pip install ReviewBoard[...]` * `pip install` * `yum install` * `zypper install` * Arbitrary shell commands This is all done by running `run_install_method()` and passing in the appropriate arguments. It will be used for package installation in an upcoming change.	aef213fb171d5ea16585765e04884630e7edcc21

Diff:

Revision 3 (+2016 -2)

Show changes

	rbinstall/errors.py
	rbinstall/install_methods.py
	rbinstall/tests/test_install_methods.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

rbinstall/install_methods.py (Diff revision 3)
The issue has been resolved. Show all issues
```
'typing.Optional' imported but unused

Column: 1
Error code: F401
```

Change Summary:

Removed an unused import.

Commits:

	Summary	ID
	Add support for installing packages using a variety of methods. This introduces an abstraction layer for installing packages using a variety of methods. This includes: * `apt-get build-dep` * `apt-get install` * `brew install` * `curl <url> \| pythonX.Y` * `pacman` * `pip install ReviewBoard[...]` * `pip install` * `yum install` * `zypper install` * Arbitrary shell commands This is all done by running `run_install_method()` and passing in the appropriate arguments. It will be used for package installation in an upcoming change.	aef213fb171d5ea16585765e04884630e7edcc21
	Add support for installing packages using a variety of methods. This introduces an abstraction layer for installing packages using a variety of methods. This includes: * `apt-get build-dep` * `apt-get install` * `brew install` * `curl <url> \| pythonX.Y` * `pacman` * `pip install ReviewBoard[...]` * `pip install` * `yum install` * `zypper install` * Arbitrary shell commands This is all done by running `run_install_method()` and passing in the appropriate arguments. It will be used for package installation in an upcoming change.	43bdc609d3ea98d546a9ba0c297ada8d7095dbd6

Diff:

Revision 4 (+2016 -2)

Show changes

	rbinstall/errors.py
	rbinstall/install_methods.py
	rbinstall/tests/test_install_methods.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (e221efc)