Summary

Add utilities for running install processes and outputting debug info.

Review Request #13462 — Created Dec. 26, 2023 and submitted Jan. 12, 2024, 3:57 p.m.

Information

Owner

chipx86

Repository

rbinstall

Branch

master

Bugs

Depends On

~~13460~~

Blocks

13463

Reviewers

Groups

reviewboard

People

Description

The new rbinstall.process module includes two utilities, debug() and
run().

debug() will output debug information to the console when the
RBINSTALL_DEBUG environment variable is set to 1, optionally showing a
custom prefix.

run() will run a command, streaming output and raising an exception on
errors. If RBINSTALL_DRY_RUN is set to 1, then the command won't
actually be run.

Testing Done

Successfully tested these with the rest of the installer.

Commits

Summary	ID
Add utilities for running install processes and outputting debug info. The new `rbinstall.process` module includes two utilities, `debug()` and `run()`. `debug()` will output debug information to the console when the `RBINSTALL_DEBUG` environment variable is set to 1, optionally showing a custom prefix. `run()` will run a command, streaming output and raising an exception on errors. If `RBINSTALL_DRY_RUN` is set to 1, then the command won't actually be run.	0ca2d075e1afd8e604be6d21707b15ae93c47079

Summary

Add utilities for running install processes and outputting debug info.

The new `rbinstall.process` module includes two utilities, `debug()` and `run()`. `debug()` will output debug information to the console when the `RBINSTALL_DEBUG` environment variable is set to 1, optionally showing a custom prefix. `run()` will run a command, streaming output and raising an exception on errors. If `RBINSTALL_DRY_RUN` is set to 1, then the command won't actually be run.

0ca2d075e1afd8e604be6d21707b15ae93c47079

flake8 passed.

JSHint passed.

Change Summary:


Added keyword arguments for capturing executed commands, specifying a command to use for display purpose, performing a dry-run, and running the process in a raw (uncaptured) mode.
Removed the DRY_RUN environment variable default. This will eventually be re-implemented in main().
Added join_cmdline for serializing a list of command line arguments to a string.

Commits:

	Summary	ID
	Add utilities for running install processes and outputting debug info. The new `rbinstall.process` module includes two utilities, `debug()` and `run()`. `debug()` will output debug information to the console when the `RBINSTALL_DEBUG` environment variable is set to 1, optionally showing a custom prefix. `run()` will run a command, streaming output and raising an exception on errors. If `RBINSTALL_DRY_RUN` is set to 1, then the command won't actually be run.	8057a8e7f94f4dfd7d130e12b776d173da1d7e4d
	Add utilities for running install processes and outputting debug info. The new `rbinstall.process` module includes two utilities, `debug()` and `run()`. `debug()` will output debug information to the console when the `RBINSTALL_DEBUG` environment variable is set to 1, optionally showing a custom prefix. `run()` will run a command, streaming output and raising an exception on errors. If `RBINSTALL_DRY_RUN` is set to 1, then the command won't actually be run.	20ba75cadb4d87b94e983cc018a3b1569188014c

Diff:

Revision 2 (+498)

Show changes

	rbinstall/errors.py
	rbinstall/process.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Change Summary:

Fixed handling non-0 exit codes when running commands in raw mode.

Commits:

	Summary	ID
	Add utilities for running install processes and outputting debug info. The new `rbinstall.process` module includes two utilities, `debug()` and `run()`. `debug()` will output debug information to the console when the `RBINSTALL_DEBUG` environment variable is set to 1, optionally showing a custom prefix. `run()` will run a command, streaming output and raising an exception on errors. If `RBINSTALL_DRY_RUN` is set to 1, then the command won't actually be run.	20ba75cadb4d87b94e983cc018a3b1569188014c
	Add utilities for running install processes and outputting debug info. The new `rbinstall.process` module includes two utilities, `debug()` and `run()`. `debug()` will output debug information to the console when the `RBINSTALL_DEBUG` environment variable is set to 1, optionally showing a custom prefix. `run()` will run a command, streaming output and raising an exception on errors. If `RBINSTALL_DRY_RUN` is set to 1, then the command won't actually be run.	0ca2d075e1afd8e604be6d21707b15ae93c47079

Diff:

Revision 3 (+498)

Show changes

	rbinstall/errors.py
	rbinstall/process.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to master (cf5d342)